- ๐ฎ๐ทIran tsotoodeh
Could not reproduce under 9.5.3 and 10.0.3. Should be considered fixed by now.
- Status changed to Needs review
about 2 years ago 3:32pm 12 February 2023 - ๐ท๐บRussia maximpodorov
That was too optimistic to mark this issue as fixed.
- ๐ฎ๐ทIran tsotoodeh
That was too optimistic to mark this issue as fixed.
Out of misunderstanding! glad that the team members are aware and noticed maximpodorov.
- Status changed to Needs work
about 2 years ago 6:57pm 20 February 2023 - ๐บ๐ธUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request โ as a guide.
Appears last patch had a failure.
- Merge request !11192Issue #3004425: Date formats with abbreviated month name (M) and ordinal suffix are not translated using context โ (Open) created by codebymikey
Support for ordinal suffixes is a bit more complicated (e.g. https://www.omniglot.com/language/dates/welsh.htm), but providing some translation is better than using English ordinal text within a different language.
And for the more complicated ones, an ordinal dot could could be used.
Available reference: https://3v4l.org/jXP5l#v8.4.4
Test failures are due to a separate issue with functional JS.
- ๐บ๐ธUnited States smustgrave
Hiding patches.
I've ran the javascript tests 3 times but seem to fail consistently.
Not sure what happened, but the changes didn't touch or should break any of the functional JS tests.
It's now passing following a rerun without any specific changes, so it's something caused by upstream or Gitlab CI as I've experienced something similar in the past.
- ๐บ๐ธUnited States smustgrave
Odd, definitely ran multiple times guess 4th time was the charm!
Test-only feature has already been ran and shows coverage for the change.
Don't see any open threads or remaining tasks, believe this is good.