"Comments per page" setting cannot be configured to "all comments"

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Moving back for the tests.

Good job expanding on an existing test case.

Think we need to also test that when it's set to 0 that all comments are appearing.

Added the tests as per #18

Tests look good!

Good work

+++ b/core/modules/comment/src/Plugin/Field/FieldType/CommentItem.php
@@ -118,8 +118,9 @@ public function fieldSettingsForm(array $form, FormStateInterface $form_state) {
+      '#description' => $this->t('Enter 0 for show all comments.'),

Not a native English speaker, but shouldn't this be "Enter 0 for _showing_ all comments"?

I think it should probably be "Enter 0 to show all comments"

That looks good.

Looks good.

Committed 98217b5 and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.