[random test failure] Random failure in CommentStatisticsTest

Back with a vengeance: https://www.drupal.org/pift-ci-job/2692252 →

Let's first proof that running \Drupal\Tests\comment\Functional\CommentStatisticsTest and \Drupal\Tests\comment\Functional\CommentStatisticsTest alone produces the random test failure.

Here's a patch that runs only \Drupal\Tests\comment\Functional\CommentStatisticsTest 1500 times.

Hmm, this issue _is_ old...

The normal routine to prove a random failure is fixed is to run the failing patch and the patch with the fix at the same time, whilst the latter has to have ~8000 - 10.000 failure free runs to prove it's credibility.

Let's do that here.

That's 6 * 5000 = 30.000 failure free runs.

Good enough for me, here's the actual patch.

Meh!

Hmm, editing this in 2 tabs appareantly ate the visibility of patch #16 and I don't see it in the file list to restore that visibility.
Re-upping

LGTM

Would normally push back against changing admin settings in the UI (unless that's what we're testing), but given how long this has been random, let's make it not random again and any refactoring can happen on a firmer footing.

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.