The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- last update
over 1 year ago Custom Commands Failed - @joachim opened merge request.
- Status changed to Needs review
over 1 year ago 11:52am 14 July 2023 - 🇬🇧United Kingdom joachim
New MR on 11.x using the new callable resolver service.
- Status changed to Needs work
over 1 year ago 3:00pm 14 July 2023 - Status changed to Needs review
over 1 year ago 4:08pm 14 July 2023 - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - Status changed to Needs work
over 1 year ago 8:48pm 17 July 2023 - Status changed to Needs review
over 1 year ago 5:28pm 18 July 2023 - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - Status changed to Needs work
over 1 year ago 4:30pm 24 July 2023 - Status changed to Needs review
over 1 year ago 6:29pm 24 July 2023 - last update
over 1 year ago 29,868 pass, 1 fail - Status changed to Needs work
over 1 year ago 4:11pm 7 August 2023 - 🇺🇸United States smustgrave
Not sure if the failure is relevant to this issue but can't rerun so MR may need to be updated.
- last update
over 1 year ago 29,944 pass, 1 fail - Status changed to Needs review
over 1 year ago 6:27pm 7 August 2023 - last update
over 1 year ago 29,949 pass, 1 fail - Status changed to Needs work
over 1 year ago 2:50pm 17 August 2023 - last update
about 1 year ago Custom Commands Failed - 🇬🇧United Kingdom joachim
The test is failing because the callback is not behaving in the same way.
This code in the test + some dumping:
$entity = EntityTest::create([ 'field_test_file' => [ 'entity' => $file, ], ]); dump('owner ID in test'); dump($file->getOwnerId());
On 11.x, getOwnerId() is NULL. On the MR, it's 0.
I think we're actually fixing a bug here. The entity owner shouldn't ever be NULL because EntityOwnerTrait::getDefaultEntityOwner() returns the current user.
Any ideas how that is happening? I feel it's not a rabbithole we should go down -- rather we should fix the test, as it seems to me that currently it's only passing by accident.