Move boilerplate code for cache metadata to base class

Created on 10 May 2018, over 6 years ago
Updated 31 January 2023, almost 2 years ago

Problem/Motivation

Patch from #2915594-18: SessionCacheContext class should implement CacheContextInterface β†’ moves similar implementations of getCacheableMetadata() method to RequestStackCacheContextBase cos they all do return new CacheableMetadata();

Proposed resolution

Make RequestStackCacheContextBase implements CacheContextInterface for that purpose

Remaining tasks

get agreement from subsystem maintainers

User interface changes

No

API changes

RequestStackCacheContextBase now implements CacheContextInterface

Data model changes

πŸ“Œ Task
Status

Needs work

Version

10.1 ✨

Component
CacheΒ  β†’

Last updated 3 days ago

Created by

πŸ‡«πŸ‡·France andypost

Live updates comments and jobs are added and updated live.
  • Needs change record

    A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Can't believe this one still applied to D10 with no issues

    @andypost any concern about the point brought up by @borisson_ in #2?

    See it was tagged for change record which still would need to happen I believe.

    Thanks!

Production build 0.71.5 2024