- π©πͺGermany Anybody Porta Westfalica
Is this still an issue with 2.0.x? If yes, please update the version and set the status active again with clear steps or (best) with a test showing what's broken.
2.0.x is the active development branch.
If nobody replies, we should assume this is fixed and close this issue outdated.
Thanks!
- Status changed to Needs work
over 1 year ago 2:28pm 23 June 2023 - π«π·France andypost
The issue still remain as 2.x also hard-coding both settings https://git.drupalcode.org/project/views_infinite_scroll/-/blob/2.0.x/js...
patch just needs re-roll
- π©πͺGermany Anybody Porta Westfalica
Should we close β¨ trigger ajax load on scroll percentage threshold rather than random scroll Postponed: needs info as duplicate?
- Status changed to Needs review
over 1 year ago 3:59pm 29 June 2023 - last update
over 1 year ago Composer error. Unable to continue. - last update
over 1 year ago 1 pass, 2 fail - π©πͺGermany Anybody Porta Westfalica
Thanks @YurkinPark! Cool :)
I just thought, if we should combine this with π Add settings to additionally focus on a new appearing element Postponed would that make sense? - last update
over 1 year ago Composer error. Unable to continue. - π·πΊRussia YurkinPark
@Anybody i think better to keep independent tickets because here we solving issue related to threshold and delay, in π Add settings to additionally focus on a new appearing element Postponed - another stuff.
- last update
over 1 year ago 2 pass - π©πͺGermany Anybody Porta Westfalica
Thanks @YurkinPark okay let's keep them separate. Perhaps it would speed up, if you'd provide the patch as MR, so the mainainer (I'm not) can review merge it easier?
- π©πͺGermany Anybody Porta Westfalica
@Grevil would you mind to review this and take it over the finish line?
- First commit to issue fork.
- πΊπΈUnited States GBlicharz
Minor update to the #33 patch to fix the error in InfiniteScrollTest.php
- last update
8 months ago Patch Failed to Apply - πΊπΈUnited States GBlicharz
Minor update to the #33 patch to fix the error in InfiniteScrollTest.php
- last update
8 months ago Patch Failed to Apply - πΊπΈUnited States GBlicharz
Sorry for the bad patch attempts. Longtime developer, but I have never updated a Drupal module/patch before! Hopefully the third time is the charm! It is just a minor update to #2950901-33: Allow setting scroll threshold and delay β