- π§πͺBelgium dieterholvoet Brussels
We should probably get in β¨ Add entity Label views field Fixed first so we can add a label column to these views.
- π§πͺBelgium dieterholvoet Brussels
We should probably get in β¨ Add entity Label views field Fixed first so we can add a label column to these views.
- Status changed to Needs review
4 months ago 10:22pm 2 September 2024 - π«π·France dqd London | N.Y.C | Paris | Hamburg | Berlin
What we maybe should collect on thoughts before we set NW is: what we expect from implementing Views support for ECK or if it isn't actually rather an issue on a larger scope (core,Views, custom entities Views support as a whole). I mean Views support for custom entities is limited because of the originally nature or core (Nodes only) and custom entities not only because of not having a mandatory label but also because Views was born in the "Node era". Says: Views maybe do not provide an easy way to "clone" the node views possibilities from the side of another module. But maybe from Views side itself.
Note: You can already build lists of custom entity type content with the contrib module config_views, if some of you didn't know yet. We use it regularly on a team software project we build for in-house use. Which is a candidate for core, if you would ask me. Maybe we should take a look over there and investigate what's good and what's not. Or merge forces... But it is limited in comparison to what Views provide as options and settings/filters for nodes.
And again, I am pretty sure there is already a core issue for that problem on a larger scale. But I haven't looked yet. If not I consider to start one after talking with some folks on Slack.
BTW: edited/cleaned up the issue summary and title accordingly to what has been discussed here.
- π«π·France dqd London | N.Y.C | Paris | Hamburg | Berlin
Better title (order of words for better readability).
- π«π·France dqd London | N.Y.C | Paris | Hamburg | Berlin
Sorry for the noise but my last comments need to be edited and maybe the issue title too (again). From what I found out (sadly afterwards) ECK entity types are already able to get listed by Views (without config_views additional contrib module, my mistake in previous comments). Also, you are able (if you want) to override the ECK content list pages by Views this way by simply using the same path. So maybe this issue is outdated and needs clearance by project maintainers. Not sure if it his has been fixed in another issue or has been fixed by changes in core and Views but in the moment (if I understand the issue request correctly), I think this issue is actually outdated or fixed. Set it to postponed in the hope somebody can make a final decision on this.
- π§πͺBelgium dieterholvoet Brussels
You can make these views manually, but I think there's still value in having them created automatically.
- π«π·France dqd London | N.Y.C | Paris | Hamburg | Berlin
That makes far more sense now. +1 ! #17 and #18: 100% agreed. @Damien, thanks for the better title. We maybe should add something like "default" or "on install" in title then, to distinguish it better from the fact that ECK already supports Views? That was my initial confusion.
Let me update the title and the issue summary accordingly one more time. Hopefully you/we all like it and we have a narrowed down scope/route to go on now finally.