Language label logic when installing with language, adding and editing languages is confusing

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Does this require a change record?

Apologize if I missed it but has

Create additional languages with the translated label into the correct language (==langcode property). Look into creating a translation. Maybe that could be a follow-up because it is likely more complicated.

been addressed or a follow up made?

Also are the steps in the IS still the best way to test this?

There's no follow-up, but I'm not sure about if we even need to do that. The first part happens here, it's only that we could also create a translation already of that language, but that sounds more a feature than a bugfix to me.

The steps should still be accurate and this still applies.

Fun seeing my boilerplate message from when the #needs-review-queue started

Thanks @berdir for following up.

Verified the tests fail without the fixes
Applied the patch #36
Did an install of Standard profile with a different language other then English and no issues there
Added another language without issue.

The last submitted patch, 36: 2927338-36.patch, failed testing. View results →

Updated and created a merge request.

Was previous RTBC so restoring status.

After reading the issue summary here and the comments I still did not understand what this is fixing. To figure that out I installed in Italian on two sites, one without the diff applied and one with the diff applied. I then saw that there is a change to the text in the in the language switcher. So, this affects what is displayed in the language switcher. What else is affected?

Should the title then be, 'Display the translated language name when installing, adding or editing a language' ?

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Added phpcs exclude like the the referenced case.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fixed new phpcs fail.

> Should the title then be, 'Display the translated language name when installing, adding or editing a language' ?

That's one aspect of it, but it's more. It's also about preventing that the config entity langcode property changes. No strong feelings on the title, whatever helps to finally land this :)

Tried to take both suggestions hope it works!

Re-ran failures and they were random, so restoring status