Make non-Settings Tray helper methods out of SettingsTrayJavascriptTestBase, and use them instead of assertWaitOnAjaxRequest()

Created on 11 October 2017, about 7 years ago

Updated 10 August 2024, 5 months ago

Problem/Motivation

There are a couple methods on SettingsTrayJavascriptTestBase that are more generically useful.
\Drupal\Tests\settings_tray\FunctionalJavascript\SettingsTrayJavascriptTestBase::assertPageLoadComplete
\Drupal\Tests\settings_tray\FunctionalJavascript\SettingsTrayJavascriptTestBase::assertAllContextualLinksLoaded
\Drupal\Tests\settings_tray\FunctionalJavascript\SettingsTrayJavascriptTestBase::waitForNoElement

Proposed resolution

Move these to either:
\Drupal\Tests\contextual\FunctionalJavascript\ContextualLinkClickTrait
\Drupal\FunctionalJavascriptTests\JSWebAssert

Remaining tasks

Decide where to move them

Go through tests using ContextualLinkClickTrait and evaluate their usage of ::assertWaitOnAjaxRequest(), replacing them with more targeted asserts/waits.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

📌 Task

Status

Closed: outdated

Version

11.0 🔥

Component

Contextual →

Last updated 3 months ago

Maintained by
🇦🇺Australia @larowlan

Created by

🇺🇸United States tim.plunkett Philadelphia

Live updates comments and jobs are added and updated live.

Novice
It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 5 months ago →
🇳🇿New Zealand quietone
This is now outdated

Drupal\Tests\settings_tray\FunctionalJavascript\SettingsTrayJavascriptTestBase::assertPageLoadComplete ->
\Drupal\Tests\system\FunctionalJavascript\OffCanvasTestBase::assertPageLoadComplete
\Drupal\Tests\settings_tray\FunctionalJavascript\SettingsTrayJavascriptTestBase::assertAllContextualLinksLoaded ->
\Drupal\Tests\system\FunctionalJavascript\OffCanvasTestBase::assertAllContextualLinksLoaded
\Drupal\Tests\settings_tray\FunctionalJavascript\SettingsTrayJavascriptTestBase::waitForNoElement ->
Drupal\FunctionalJavascriptTests\JSWebAssert::assertNoElementAfterWait()

The work was done in these issues, #2902191: Determine cause and fix random fail in \Drupal\Tests\settings_tray\FunctionalJavascript\SettingsTrayBlockFormTest::testBlocks → and #3097453: Remove system.module BC layers → .

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024