Fix for Unit Test on Windows

$ ../vendor/bin/phpunit tests/Drupal/Tests/Component/FileCache/FileCacheTest.php PHPUnit 9.5.26 by Sebastian Bergmann and contributors. Testing Drupal\Tests\Component\FileCache\FileCacheTest F.F. 4 / 4 (100%) Time: 00:30.572, Memory: 10.00 MB There were 2 failures: 1) Drupal\Tests\Component\FileCache\FileCacheTest::testGet Failed asserting that null matches expected 42. D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\Constraint\Equality\IsEqual.php:96 D:\htdocs\drupal\core\tests\Drupal\Tests\Component\FileCache\FileCacheTest.php:60 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestResult.php:728 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestSuite.php:673 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\TestRunner.php:661 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:144 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:97 2) Drupal\Tests\Component\FileCache\FileCacheTest::testSet Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ Array ( 'prefix:test:D:\htdocs\drupal\core\tests\Drupal\Tests\Component\FileCache\Fixtures\llama-23.txt' => Array ( 'mtime' => 1661603362 - 'filepath' => 'D:\htdocs\drupal\core\tests\Drupal\Tests\Component\FileCache\Fixtures\llama-23.txt' + 'filepath' => 'D:\htdocs\drupal\core\tests\Drupal\Tests\Component\FileCache/Fixtures/llama-23.txt' 'data' => 23 ) ) D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\Constraint\Equality\IsEqual.php:96 D:\htdocs\drupal\core\tests\Drupal\Tests\Component\FileCache\FileCacheTest.php:116 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestResult.php:728 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestSuite.php:673 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\TestRunner.php:661 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:144 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:97 FAILURES! Tests: 4, Assertions: 8, Failures: 2.

$ ../vendor/bin/phpunit tests/Drupal/Tests/Component/ClassFinder/ClassFinderTest.php PHPUnit 9.5.26 by Sebastian Bergmann and contributors. Testing Drupal\Tests\Component\ClassFinder\ClassFinderTest F 1 / 1 (100%) Time: 00:00.253, Memory: 10.00 MB There was 1 failure: 1) Drupal\Tests\Component\ClassFinder\ClassFinderTest::testFindFile Failed asserting that 'D:\htdocs\drupal\core\tests\Drupal\Tests\Component\ClassFinder\ClassFinderTest.php' ends with "core/tests/Drupal/Tests/Component/ClassFinder/ClassFinderTest.php". D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\Constraint\Constraint.php:122 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\Constraint\Constraint.php:55 D:\htdocs\drupal\core\tests\Drupal\Tests\Component\ClassFinder\ClassFinderTest.php:23 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestResult.php:728 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestSuite.php:673 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\TestRunner.php:661 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:144 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:97 FAILURES! Tests: 1, Assertions: 1, Failures: 1.

$ ../vendor/bin/phpunit tests/Drupal/Tests/Component/Discovery/YamlDirectoryDiscoveryTest.php PHPUnit 9.5.26 by Sebastian Bergmann and contributors. Testing Drupal\Tests\Component\Discovery\YamlDirectoryDiscoveryTest FFFF 4 / 4 (100%) Time: 00:00.416, Memory: 10.00 MB There were 4 failures: 1) Drupal\Tests\Component\Discovery\YamlDirectoryDiscoveryTest::testDiscovery Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ Array &0 ( 'id' => 'item1' 'name' => 'test1 item 1' - '_discovered_file_path' => 'vfs://modules/test_1/subdir1/item_1.test.yml' + '_discovered_file_path' => 'vfs://modules/test_1/subdir1\item_1.test.yml' ) D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\Constraint\Constraint.php:122 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\Constraint\IsIdentical.php:79 D:\htdocs\drupal\core\tests\Drupal\Tests\Component\Discovery\YamlDirectoryDiscoveryTest.php:83 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestResult.php:728 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestSuite.php:673 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\TestRunner.php:661 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:144 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:97 2) Drupal\Tests\Component\Discovery\YamlDirectoryDiscoveryTest::testDiscoveryAlternateId Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ Array &0 ( 'alt_id' => 'item1' 'id' => 'ignored' - '_discovered_file_path' => 'vfs://modules/test_1/item_1.test.yml' + '_discovered_file_path' => 'vfs://modules/test_1\item_1.test.yml' ) D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\Constraint\Constraint.php:122 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\Constraint\IsIdentical.php:79 D:\htdocs\drupal\core\tests\Drupal\Tests\Component\Discovery\YamlDirectoryDiscoveryTest.php:116 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestResult.php:728 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestSuite.php:673 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\TestRunner.php:661 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:144 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:97 3) Drupal\Tests\Component\Discovery\YamlDirectoryDiscoveryTest::testDiscoveryNoIdException Failed asserting that exception message 'The vfs://modules/test_1\item_1.test.yml contains no data in the identifier key 'id'' contains 'The vfs://modules/test_1/item_1.test.yml contains no data in the identifier key 'id''. D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\Constraint\Constraint.php:122 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\Constraint\Constraint.php:55 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestResult.php:728 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestSuite.php:673 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\TestRunner.php:661 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:144 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:97 4) Drupal\Tests\Component\Discovery\YamlDirectoryDiscoveryTest::testDiscoveryInvalidYamlException Failed asserting that exception message 'The vfs://modules/test_1\item_1.test.yml contains invalid YAML' contains 'The vfs://modules/test_1/item_1.test.yml contains invalid YAML'. D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\Constraint\Constraint.php:122 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\Constraint\Constraint.php:55 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestResult.php:728 D:\htdocs\drupal\vendor\phpunit\phpunit\src\Framework\TestSuite.php:673 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\TestRunner.php:661 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:144 D:\htdocs\drupal\vendor\phpunit\phpunit\src\TextUI\Command.php:97 FAILURES! Tests: 4, Assertions: 6, Failures: 4.

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇳🇱Netherlands spokje
Just ran all three changed test classes successfully on a Windows 11 machine using XAMPP and using MINGW64 as bash shell.
Comment over 1 year ago →
🇺🇸United States neclimdul Houston, TX
Still not plused about the str_replace use. I guess I'll need to write a different patch though to get it addressed. Does anyone have steps to recreate these failures?
Comment over 1 year ago →
🇺🇸United States neclimdul Houston, TX
Sorry, that was a genuine request. I don't know how to recreate this to test this and try some alternate approaches.
Status changed to Needs review over 1 year ago11:47am 17 March 2023
Comment over 1 year ago →
🇬🇧United Kingdom catch
Moving this back to needs review. Pinged @Spokje in slack to see if he checked the failure case (which I understand to be just running these unit tests on a windows machine, but have no way to validate).

The obvious alternative to str_replace() would be a big concat of the string which was in earlier patches - which is guaranteed not to replace anything it shouldn't since it'd all be hardcoded.
Status changed to RTBC over 1 year ago12:08pm 17 March 2023
Comment over 1 year ago →
🇳🇱Netherlands spokje
Pinged @Spokje in slack to see if he checked the failure case (which I understand to be just running these unit tests on a windows machine, but have no way to validate).

Yep, the test failures in the IS is me running the tests on the 10.1.x branch without any patches: https://www.drupal.org/node/2911377/revisions/view/12852063/12894061 →

Back to RTBC
Comment over 1 year ago →
System Message
The last submitted patch, 44: 2911377-44.patch, failed testing. View results →
Comment over 1 year ago →
🇺🇸United States smustgrave
Seemed random
Comment over 1 year ago →
System Message
The last submitted patch, 44: 2911377-44.patch, failed testing. View results →
Comment over 1 year ago →
🇳🇱Netherlands spokje
Random Failure, back to RTBC.
Comment over 1 year ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Comment over 1 year ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed to 10.1.x and backported to 10.0.x and 9.5.x to keep things consistent

Posthumously updating the priority to minor.
Comment over 1 year ago →
System Message

larowlan → committed 5b91abc9 on 10.0.x
Issue #2911377 by smustgrave, ProFire, MerryHamster, ranjith_kumar_k_u,...
Comment over 1 year ago →
System Message

larowlan → committed e1f56ada on 10.1.x
Issue #2911377 by smustgrave, ProFire, MerryHamster, ranjith_kumar_k_u,...
Status changed to Fixed over 1 year ago1:09am 29 March 2023

Comment over 1 year ago →

System Message

larowlan → committed 8ec568f2 on 9.5.x

Issue #2911377 by smustgrave, ProFire, MerryHamster, ranjith_kumar_k_u,...

Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix for Unit Test on Windows

Problem

Proposed resolution

Comments & Activities