Role assignment from attributes does not work when provisioning accounts

As there is a new version for simplesamlphp_auth, I've created a reroll for this patch. The code is exactly the same, it just moved some lines.

The function "moduleHandler->getImplementations()" is deprecated in D10, so in order to keep it working on D10 i've adjusted the code. With these adjustments it should be compatible with D9 and D10.

Confirming that with the latest patch I can login as a new user and get the right roles assigned to the user with Drupal 10.

I forgot to replace a part of the example I used, here is the updated version.

I rerolled the patch since the previous one could not be applied any longer.

I needed to make some changes to the rerolled patch after we discovered some changed behavior on our site. We had been using the patch in #11 🐛 Role assignment from attributes does not work when provisioning accounts Needs review , and it appears the reroll changed how it worked slightly. The way our SSO setup is configured, you get returned to Drupal right after registering, and should then be logged in. What we started seeing after applying the reroll in #21, was that the user was not instantly logged in. It seems the new patch started doing
return $account;
Where the #11 patch was keeping what the module was already doing.

$this->synchronizeUserAttributes($account, TRUE);
return $this->externalauth->userLoginFinalize($account, $authname, 'simplesamlphp_auth');

This new patch puts it back to the previous code, so that the user's attributes get synced and they are logged in at the end.

I think this patch needs work as it places invocation of roleMatchSync() inside the condition for new account, so role sync will only be evaluated for newly provisioned accounts and not for subsequent logins.

Could not understand what i did wrong, checked issue queue. Found this and applied patch in #22
Now it works as intended

Thank you!