- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 12:38pm 23 June 2023 - Status changed to Needs work
about 1 year ago 4:41pm 23 June 2023 - 🇵🇭Philippines roberttabigue
Hi @RohitRawat676,
Confirmed patch #8 is applied cleanly.
Applied to Commerce Adyen with 8.x-1.x-dev version and with the Drupal core version of 9.5.x.
Checking patch commerce_adyen.install... Checking patch src/Adyen/Authorisation/Request.php... Checking patch src/Adyen/Authorisation/Response.php... Checking patch src/Adyen/Authorisation/Signature.php... Checking patch src/Adyen/Facade.php... Checking patch src/Adyen/Modification.php... Applied patch commerce_adyen.install cleanly. Applied patch src/Adyen/Authorisation/Request.php cleanly. Applied patch src/Adyen/Authorisation/Response.php cleanly. Applied patch src/Adyen/Authorisation/Signature.php cleanly. Applied patch src/Adyen/Facade.php cleanly. Applied patch src/Adyen/Modification.php cleanly.However, I'm still getting PHPCS errors:
I ran this command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml commerce_adyen/
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/commerce_adyen.routing.yml --------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------- 8 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 16 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction --------------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/README.md ---------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------- 39 | WARNING | Line exceeds 80 characters; contains 84 characters 41 | WARNING | Line exceeds 80 characters; contains 87 characters 49 | WARNING | Line exceeds 80 characters; contains 83 characters 57 | WARNING | Line exceeds 80 characters; contains 135 characters 63 | WARNING | Line exceeds 80 characters; contains 88 characters ---------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/src/PluginForm/BoletoPaymentForm.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 41 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 42 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 48 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 77 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/src/PluginForm/OpenInvoicePaymentForm.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 42 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 44 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 45 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 52 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 59 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 65 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 66 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 72 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 101 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 106 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/src/Adyen/Refund.php ---------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 7 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ---------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/src/Adyen/Modification.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 119 | WARNING | Exceptions should not be translated 119 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/src/Adyen/Authorisation/Response.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 85 | WARNING | Exceptions should not be translated 85 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 95 | WARNING | Exceptions should not be translated 95 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/src/Adyen/Authorisation/Request.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 52 | WARNING | Exceptions should not be translated 52 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 125 | WARNING | Exceptions should not be translated 125 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 477 | WARNING | Exceptions should not be translated 477 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/src/Adyen/Controller/Payment.php --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------- 118 | WARNING | Unused variable $order. 184 | WARNING | Unused variable $order. --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/src/Adyen/Capture.php ---------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 7 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ---------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/src/Adyen/Notification.php --------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name --------------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/src/Plugin/Commerce/PaymentGateway/OpenInvoice.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 126 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 127 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 131 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 132 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 138 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 140 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 142 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 143 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 144 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 151 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 152 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/src/Plugin/Commerce/PaymentGateway/Boleto.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 126 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 127 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 131 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 132 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 138 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 140 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 142 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 143 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 144 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 151 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 152 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------------------------------------------------Moving this now to Needs work.
Thank you!
- Assigned to nitin_lama
- Status changed to Needs review
about 1 year ago 10:37am 27 June 2023 - Issue was unassigned.
- Status changed to Needs work
12 months ago 2:29pm 3 July 2023 - 🇵🇭Philippines roberttabigue
Hi @nitin_lama,
I reviewed your changes and confirmed the Patch was applied cleanly.
Checking patch README.md... Checking patch commerce_adyen.install... Checking patch src/Adyen/Authorisation/Request.php... Checking patch src/Adyen/Authorisation/Response.php... Checking patch src/Adyen/Authorisation/Signature.php... Checking patch src/Adyen/Capture.php... Checking patch src/Adyen/Controller/Payment.php... Checking patch src/Adyen/Facade.php... Checking patch src/Adyen/Modification.php... Checking patch src/Adyen/Refund.php... Checking patch src/Plugin/Commerce/PaymentGateway/Boleto.php... Checking patch src/Plugin/Commerce/PaymentGateway/OpenInvoice.php... Checking patch src/PluginForm/BoletoPaymentForm.php... Checking patch src/PluginForm/OpenInvoicePaymentForm.php... Applied patch README.md cleanly. Applied patch commerce_adyen.install cleanly. Applied patch src/Adyen/Authorisation/Request.php cleanly. Applied patch src/Adyen/Authorisation/Response.php cleanly. Applied patch src/Adyen/Authorisation/Signature.php cleanly. Applied patch src/Adyen/Capture.php cleanly. Applied patch src/Adyen/Controller/Payment.php cleanly. Applied patch src/Adyen/Facade.php cleanly. Applied patch src/Adyen/Modification.php cleanly. Applied patch src/Adyen/Refund.php cleanly. Applied patch src/Plugin/Commerce/PaymentGateway/Boleto.php cleanly. Applied patch src/Plugin/Commerce/PaymentGateway/OpenInvoice.php cleanly. Applied patch src/PluginForm/BoletoPaymentForm.php cleanly. Applied patch src/PluginForm/OpenInvoicePaymentForm.php cleanly.However, I'm still seeing a couple of PHPCS errors:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/commerce_adyen.routing.yml --------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------- 8 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 16 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction --------------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/commerce_adyen/src/Adyen/Notification.php --------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name --------------------------------------------------------------------------------------------------------------------- Time: 592ms; Memory: 12MBMoving this again to Needs work.
Thank you!
- First commit to issue fork.
- @frederikvho opened merge request.
- Status changed to Needs review
12 months ago 11:47am 4 July 2023 - 🇧🇪Belgium Frederikvho Belgium
Please check the newest merge request.
The other merge request's fork was branched from 7.x, this one is 8.x.Summary:
Applied the existing patch from #11
+
Added extra fixes for remaining phpcs warnings that were also addressed in #13 - Status changed to RTBC
12 months ago 4:16pm 4 July 2023 - 🇵🇭Philippines roberttabigue
Hi,
I reviewed the new changes made by @Frederikvho and was applied cleanly.
Checking patch README.md... Hunk #1 succeeded at 36 (offset -2 lines). Hunk #2 succeeded at 48 (offset -2 lines). Hunk #3 succeeded at 57 (offset -2 lines). Checking patch commerce_adyen.install... Checking patch commerce_adyen.routing.yml... Checking patch src/Adyen/Authorisation/Request.php... Checking patch src/Adyen/Authorisation/Response.php... Checking patch src/Adyen/Authorisation/Signature.php... Checking patch src/Adyen/Capture.php... Checking patch src/Adyen/Controller/Payment.php... Checking patch src/Adyen/Facade.php... Checking patch src/Adyen/Modification.php... Checking patch src/Adyen/Notification.php... Checking patch src/Adyen/Refund.php... Checking patch src/Plugin/Commerce/PaymentGateway/Boleto.php... Checking patch src/Plugin/Commerce/PaymentGateway/OpenInvoice.php... Checking patch src/PluginForm/BoletoPaymentForm.php... Checking patch src/PluginForm/OpenInvoicePaymentForm.php... Applied patch README.md cleanly. Applied patch commerce_adyen.install cleanly. Applied patch commerce_adyen.routing.yml cleanly. Applied patch src/Adyen/Authorisation/Request.php cleanly. Applied patch src/Adyen/Authorisation/Response.php cleanly. Applied patch src/Adyen/Authorisation/Signature.php cleanly. Applied patch src/Adyen/Capture.php cleanly. Applied patch src/Adyen/Controller/Payment.php cleanly. Applied patch src/Adyen/Facade.php cleanly. Applied patch src/Adyen/Modification.php cleanly. Applied patch src/Adyen/Notification.php cleanly. Applied patch src/Adyen/Refund.php cleanly. Applied patch src/Plugin/Commerce/PaymentGateway/Boleto.php cleanly. Applied patch src/Plugin/Commerce/PaymentGateway/OpenInvoice.php cleanly. Applied patch src/PluginForm/BoletoPaymentForm.php cleanly. Applied patch src/PluginForm/OpenInvoicePaymentForm.php cleanly.And all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twigPlease see the attached screenshots for your reference.
I'm moving this now to RTBC.
Thank you!
-
i-trokhanenko →
committed 423d3f94 on 8.x-1.x authored by
Frederikvho →
Issue #2887229 by Frederikvho, Anupam_Dhauria, nitin_lama,...
-
i-trokhanenko →
committed 423d3f94 on 8.x-1.x authored by
Frederikvho →
- Status changed to Fixed
11 months ago 8:47pm 6 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.