Originally raised this in #2563843-37: MapItem is broken for configurable fields → but now splitting this off into its own issue.
FieldItemInterface::schema() states:
/**
* ...
*
* @return array
* An empty array if there is no schema, or an associative array with the
* following key/value pairs:
* - columns: An array of Schema API column specifications, keyed by column
* name. The columns need to be a subset of the properties defined in
* propertyDefinitions().
* ...
*/
So since MapItem::schema() returns a value column, you would expect that there must be a value property defined by MapItem::propertyDefinitions().
That is no longer the case, however, since #2229181: MapItem::propertyDefinitions() claims it has a static value property, which is wrong → .
Besides clearly being a violation of the API, this breaks any widget that you try to write for MapItem as widgets rely on the aforementioned relationship between schema columns and properties. Possibly other things are broken as well, but this is the one I encountered.
Roll back #2229181: MapItem::propertyDefinitions() claims it has a static value property, which is wrong → .
Needs work
10.1 ✨
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Seems the last patch had some failures in D8 (triggered for D10)
Think we will need a test case also to show the issue.