Add support for address module

Created on 25 March 2017, almost 8 years ago
Updated 21 June 2023, over 1 year ago

Add support for the address module so address fields can get a simple_gmap formatter

✨ Feature request
Status

RTBC

Version

1.0

Component

Code

Created by

🇧🇪Belgium daften

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇨🇦Canada jglynn

    Is this going to get committed? Seems like the patch no longer applies to dev or 3.0.1

  • 🇬🇧United Kingdom Alina Basarabeanu

    The patch from #52 applies and works as expected on Drupal version 9.5.10 and simple_gmap 3.0.1

  • Status changed to Needs work over 1 year ago
  • 🇬🇧United Kingdom darrenwh Bristol

    The function urlencode in SimpleGMapTrait->viewElements line 254 is throwing a depreciated error in php 8.1

          $url_value = is_null($item->value) ? '' : urlencode($item->value);
          $address_value = is_null($item->value) ? '' : $item->value;
    
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India nishantghetiya Pune

    Fix deprecation issue #56 with the #52 patch.

  • Status changed to RTBC about 1 year ago
  • 🇬🇧United Kingdom Rob230

    Confirmed that patch #57 applies to simple_gmap
    3.1 and fixes the PHP 8.1 deprecation errors.

  • ++ , This patch #57 working fine & added map support for addressfield.

  • 🇧🇪Belgium økse

    I got an error using the fieldformatter on a field within a block while using layout builder.

    LogicException: A stray renderRoot() invocation is causing bubbling of attached assets to break.

    Attached patch fixes this. Reviewed the initial functionality based on a address field and looks good.

  • 🇧🇪Belgium økse
  • 🇧🇪Belgium økse

    Looks like I did add the wrong version. Newly attached patch is the correct one based on #57.

  • Status changed to Needs work about 1 month ago
  • 🇺🇸United States smustgrave

    Should be in an MR against 4.0.x

  • 🇺🇸United States smustgrave

    Question do we really want to copy and paste the formatter code? Feel it should be done more streamline to reduce duplicate code.
    Fixes will have to be in MRs

  • Merge request !11Resolve #2863979 "Address formatter" → (Open) created by megachriz
  • Pipeline finished with Success
    3 days ago
    Total: 166s
    #434773
  • 🇳🇱Netherlands megachriz

    I've rerolled the patch from #62 into a MR and I made the following changes:

    • Updated trait with changes from SimpleGMapFormatter.
    • Use attribute instead of annotation for SimpleGMapAddressFormatter.
    • Removed unused .orig file (simple-gmap-output.html.twig.orig).
    • Updated tests.

    Probably needs coding standard fixes (phpcs, phpstan, etc.).

    @smustgrave
    What's the duplicate code that you refer to? Most code of SimpleGMapFormatter is moved to a trait, so SimpleGMapAddressFormatter can make use of it. This is done to reduce code duplication. But perhaps I missed code duplication somewhere else?

  • Pipeline finished with Success
    about 24 hours ago
    Total: 163s
    #436473
  • Pipeline finished with Success
    about 24 hours ago
    Total: 164s
    #436478
  • 🇳🇱Netherlands megachriz

    Coding standard fixes have been done. Setting to "Needs review" for now, until it is clear what changes exactly are requested in #64.

Production build 0.71.5 2024