- 🇨🇦Canada jglynn
Is this going to get committed? Seems like the patch no longer applies to dev or 3.0.1
- 🇬🇧United Kingdom Alina Basarabeanu
The patch from #52 applies and works as expected on Drupal version 9.5.10 and simple_gmap 3.0.1
- Status changed to Needs work
over 1 year ago 3:22pm 20 September 2023 - 🇬🇧United Kingdom darrenwh Bristol
The function urlencode in SimpleGMapTrait->viewElements line 254 is throwing a depreciated error in php 8.1
$url_value = is_null($item->value) ? '' : urlencode($item->value); $address_value = is_null($item->value) ? '' : $item->value;
- Status changed to Needs review
over 1 year ago 8:55am 21 September 2023 - 🇮🇳India nishantghetiya Pune
Fix deprecation issue #56 with the #52 patch.
- Status changed to RTBC
about 1 year ago 5:25pm 22 February 2024 - 🇬🇧United Kingdom Rob230
Confirmed that patch #57 applies to simple_gmap
3.1 and fixes the PHP 8.1 deprecation errors. ++ , This patch #57 working fine & added map support for addressfield.
- 🇧🇪Belgium økse
I got an error using the fieldformatter on a field within a block while using layout builder.
LogicException: A stray renderRoot() invocation is causing bubbling of attached assets to break.
Attached patch fixes this. Reviewed the initial functionality based on a address field and looks good.
- 🇧🇪Belgium økse
Looks like I did add the wrong version. Newly attached patch is the correct one based on #57.
- Status changed to Needs work
about 1 month ago 5:42pm 23 January 2025 - 🇺🇸United States smustgrave
Question do we really want to copy and paste the formatter code? Feel it should be done more streamline to reduce duplicate code.
Fixes will have to be in MRs - 🇳🇱Netherlands megachriz
I've rerolled the patch from #62 into a MR and I made the following changes:
- Updated trait with changes from SimpleGMapFormatter.
- Use attribute instead of annotation for SimpleGMapAddressFormatter.
- Removed unused .orig file (simple-gmap-output.html.twig.orig).
- Updated tests.
Probably needs coding standard fixes (phpcs, phpstan, etc.).
@smustgrave
What's the duplicate code that you refer to? Most code of SimpleGMapFormatter is moved to a trait, so SimpleGMapAddressFormatter can make use of it. This is done to reduce code duplication. But perhaps I missed code duplication somewhere else? - 🇳🇱Netherlands megachriz
Coding standard fixes have been done. Setting to "Needs review" for now, until it is clear what changes exactly are requested in #64.