DefaultSingleLazyPluginCollection should not attempt to instantiate a NULL instance ID

Change record is simple and makes sense.

Code has coverage.

Think this is good.

+++ b/core/lib/Drupal/Core/Plugin/DefaultSingleLazyPluginCollection.php
@@ -52,7 +52,13 @@ class DefaultSingleLazyPluginCollection extends LazyPluginCollection {
+
+    if ($instance_id === NULL) {
+      @trigger_error('Instantiating %s with a NULL instance ID is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. See https://www.drupal.org/node/3302915', E_USER_DEPRECATED);
+    }
+    else {
+      $this->addInstanceId($instance_id, $configuration);
+    }

A bit nitpicky, but it won't be removed in Drupal 11, it's either going to be a type error if we explicitly type hint with string, or it'll throw an exception. Can we maybe say 'and must be a string in Drupal 11' instead?

Changed according to the suggestion given in #49

Fixed PHP CBF errors from the earlier patch.

Fixed PHP CBF errors from the earlier patch.

Trying to Fix CCF errors.

clean-up unrelated changes

The last submitted patch, 56: 2853234-56.patch, failed testing. View results →

Fix remaining message

Think I'm able to review this as the patch has gone through several changes since I last worked on it 7 months ago.

Deprecation looks good, with change record
Tests look good and fail as expected without the fix.

Think this is good.

The last submitted patch, 58: 2853234-58.patch, failed testing. View results →

This is still a problem.

Also, I just ran into a sibling issue: 🐛 DefaultSingleLazyPluginCollection::setConfiguration() accepts NULL but ConfigurableInterface::setConfiguration() does not Active .