Problem/Motivation
Fix code standard issues in paragraphs_collection. This is a low priority issue.
Proposed resolution
FILE: /root/repos/pareviewsh/pareview_temp/src/StyleDiscovery.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------
15 | ERROR | [x] There must be exactly one blank line before the tags
| | in a doc comment
94 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
109 | ERROR | [x] Use "elseif" in place of "else if"
117 | ERROR | [x] Space found before semicolon; expected "];" but
| | found "] ;"
132 | ERROR | [x] Use "elseif" in place of "else if"
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: /root/repos/pareviewsh/pareview_temp/src/StyleDiscoveryInterface.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
15 | ERROR | [ ] Missing parameter type
17 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
24 | ERROR | [ ] Doc comment short description must be on a single line,
| | further text should be a separate paragraph
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: /root/repos/pareviewsh/pareview_temp/src/GridLayoutDiscovery.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
10 | WARNING | [x] Unused use statement
80 | ERROR | [x] Use "elseif" in place of "else if"
103 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: .../repos/pareviewsh/pareview_temp/src/GridLayoutDiscoveryInterface.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
36 | ERROR | [x] Expected 1 blank line after function; 0 found
37 | ERROR | [x] The closing brace for the interface must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...areviewsh/pareview_temp/src/Tests/ParagraphsGridLayoutPluginTest.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
17 | ERROR | Missing @var tag in member variable comment
--------------------------------------------------------------------------
FILE: ...pos/pareviewsh/pareview_temp/src/Tests/ParagraphsStylePluginTest.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
17 | ERROR | [ ] Missing @var tag in member variable comment
74 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'italic'
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...areviewsh/pareview_temp/src/Tests/ParagraphsBackgroundPluginTest.php
--------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------
20 | ERROR | [ ] Missing @var tag in member variable comment
24 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'paragraphs_collection_test'
42 | ERROR | [x] Expected one space after the comma, 0 found
42 | ERROR | [x] Expected one space after the comma, 0 found
45 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
48 | ERROR | [x] There should be no white space before a closing ")"
81 | ERROR | [x] Expected one space after the comma, 0 found
90 | ERROR | [x] Expected one space after the comma, 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...os/pareviewsh/pareview_temp/src/Tests/ParagraphsCollectionUITest.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
17 | ERROR | [ ] Missing @var tag in member variable comment
48 | ERROR | [x] Expected 1 space before opening brace; found 0
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...w_temp/src/Plugin/paragraphs/Behavior/ParagraphsGridLayoutPlugin.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 5 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
13 | WARNING | [x] Unused use statement
104 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
110 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
180 | WARNING | [ ] Translatable strings must not begin or end with
| | white spaces, use placeholders with t() for
| | variables
250 | ERROR | [x] Expected 1 blank line after function; 0 found
251 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...review_temp/src/Plugin/paragraphs/Behavior/ParagraphsStylePlugin.php
--------------------------------------------------------------------------
FOUND 29 ERRORS AFFECTING 27 LINES
--------------------------------------------------------------------------
24 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5
60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
66 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5
73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5
74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
111 | ERROR | [x] Array indentation error, expected 6 spaces but found 5
119 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
121 | ERROR | [x] Expected 1 space after IF keyword; 0 found
128 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
132 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5
133 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7
134 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5
135 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
135 | ERROR | [x] Expected 1 blank line after function; 0 found
136 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
136 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 29 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...eview_temp/src/Plugin/paragraphs/Behavior/ParagraphsSliderPlugin.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
57 | ERROR | [x] Expected one space after the comma, 2 found
57 | ERROR | [x] Expected 1 space between comma and type hint
| | "EntityFieldManager"; 2 found
108 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 9
123 | ERROR | [x] Expected 1 blank line after function; 2 found
159 | ERROR | [x] Expected 1 blank line after function; 0 found
160 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...w_temp/src/Plugin/paragraphs/Behavior/ParagraphsBackgroundPlugin.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
14 | WARNING | [x] Unused use statement
46 | ERROR | [x] Expected 1 space before "?"; 2 found
54 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...iew_temp/src/Plugin/paragraphs/Behavior/ParagraphsLockablePlugin.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
12 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: /root/repos/pareviewsh/pareview_temp/paragraphs_collection.api.php
------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------
8 | ERROR | Missing short description in doc comment
36 | WARNING | Line exceeds 80 characters; contains 81 characters
48 | WARNING | Line exceeds 80 characters; contains 81 characters
------------------------------------------------------------------------
FILE: ...p/config/install/core.entity_view_display.paragraph.grid.default.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
25 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...areview_temp/modules/paragraphs_library/src/LibraryItemInterface.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
10 | ERROR | [x] There should be no white space after an opening "{"
10 | ERROR | [x] There should be no white space before a closing "}"
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...areview_temp/modules/paragraphs_library/src/Form/LibraryItemForm.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
13 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------
FILE: ...p/modules/paragraphs_library/src/Tests/ParagraphsLibraryItemTest.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
30 | ERROR | [ ] If the line declaring an array spans longer than 80
| | characters, each element should be broken into its
| | own line
57 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 're usable paragraph label (1)'
69 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 're usable paragraph label (1)'
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...aragraphs_collection_demo/src/Tests/ParagraphsCollectionDemoTest.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
14 | ERROR | [x] Expected 1 space before opening brace; found 0
104 | ERROR | [x] Functions must not contain multiple empty lines in a
| | row; found 2 empty lines
106 | ERROR | [x] Expected 1 blank line after function; 0 found
107 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...wsh/pareview_temp/modules/paragraphs_collection_demo/demo_styles.css
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
4 | ERROR | [x] CSS colours must be defined in lowercase; expected
| | #68ad52 but found #68AD52
16 | ERROR | [x] CSS colours must be defined in lowercase; expected
| | #aaccff but found #AACCFF
22 | ERROR | [x] CSS colours must be defined in lowercase; expected
| | #aaccff but found #AACCFF
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: /root/repos/pareviewsh/pareview_temp/paragraphs_collection.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
| | line
1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
Note: this is copy-pasted from https://pareview.sh/ so it's possible that not all above mentioned issues need addressing
Remaining tasks
User interface changes
API changes
Data model changes