- πΊπΈUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β as a guide.
This could use an issue summary update as it was suggested this method be deprecated.
- Status changed to Needs review
over 1 year ago 4:36pm 16 February 2023 - π¨π³China jungle Chongqing, China
public function doMail($module, $key, $to, $langcode, $params = [], $reply = NULL, $send = TRUE) { + $backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 2); + if ($backtrace[1]['class'] != 'Drupal\Core\Mail\MailManager') { + @trigger_error('Calling' . __METHOD__ . '() directly is deprecated in Drupal 10.1.0 and it will be marked as protected in Drupal 11.0.0. See https://www.drupal.org/node/NID', E_USER_DEPRECATED); + }
Deprecate it like the above?
- Status changed to Needs work
over 1 year ago 4:47pm 16 February 2023 - πΊπΈUnited States smustgrave
Not sure if it needs to be wrapped in anything. If we are deprecating the whole method it could brought be the first line of the method. Would need a test case also.