- ๐บ๐ธUnited States jaydub
I am seeing this locally as well and the patch in #17 still applies to the latest code in 8.x-1.x branch and the PHP notices go away.
- ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- last update
over 1 year ago 37 pass, 2 fail - Status changed to Needs review
over 1 year ago 7:19am 15 February 2024 - Merge request !100Issue #3013553 by Jim.M, Berdir, sasanikolic, acbramley, Alan D.,... โ (Closed) created by makbay
- Merge request !101Issue #3013553 by Jim.M, Berdir, sasanikolic, acbramley, Alan D.,... โ (Closed) created by makbay
- Status changed to Needs work
12 months ago 10:43pm 13 August 2024 - ๐ฆ๐บAustralia acbramley
Lots of people unable to reproduce this issue, I'll need steps to reproduce before reviewing code changes.
- Status changed to Postponed: needs info
7 months ago 8:10pm 16 December 2024 - First commit to issue fork.
- ๐ง๐ชBelgium dieterholvoet Brussels
dieterholvoet โ changed the visibility of the branch 8.x-1.x to hidden.
- ๐ง๐ชBelgium dieterholvoet Brussels
dieterholvoet โ changed the visibility of the branch 2.x to hidden.
- Merge request !126Fix 'Array to string conversion in Drupal\diff\Plugin\diff\Field\ImageFieldBuilder->build()' โ (Merged) created by dieterholvoet
- ๐ง๐ชBelgium dieterholvoet Brussels
The problem is that
$image_style
is set implicitly and never unset after being used. That causes this issue, since that code runs in a loop. The issue only occurs when- thumbnails are enabled in Diff
- the image is configured to be displayed in the form display with a preview image style
- there's more than 1 image in the field
It could be fixed by unsetting
$image_style
after using it, but I changed the code a bit to be more readable. I opened a new MR. - Status changed to Needs work
5 months ago 10:01pm 23 February 2025 - First commit to issue fork.
- ๐ณ๐ฟNew Zealand RoSk0 Wellington
In attempt to fix tests I've manually replicated test steps in a clean Drupal 10.3.6 installation with only Diff module installed - the output I saw on page was identical to that of the pipeline job, attaching as a screenshot below:
To me it appeared that the output produced by the module changed at some point, but the test wasn't updated to accommodate that change. However tests are passing on the latest 2.x...
I've reverted the change introduced here and saw expected output and no errors:
this is really weird as I saw all the error reported in this issue myself on a project where we want to use this module...
Will spent some more time on this
- ๐ณ๐ฟNew Zealand RoSk0 Wellington
The problem lies in the multi-valued field handling - image field in our project allows multiple image uploads.
As soon as I've changed field_image to be multivalued in the test instance and uploaded new image to a test article the same error appeared on the diff page.
Added multi-valued support and test. Everything is rudimentary as proper implementation should be done in #2840566: Make rich diff pluggable โ .
- ๐ฆ๐บAustralia acbramley
acbramley โ changed the visibility of the branch 2844337-array-to-string to hidden.
- ๐ณ๐ฟNew Zealand RoSk0 Wellington
All green again and review comments addressed.
Please review.
- Status changed to RTBC
2 months ago 3:38am 29 May 2025 -
acbramley โ
committed 5bf854fb on 2.x authored by
dieterholvoet โ
Issue #2844337 by rosk0, dieterholvoet, acbramley, neelam.chaudhary,...
-
acbramley โ
committed 5bf854fb on 2.x authored by
dieterholvoet โ
- ๐ฆ๐บAustralia acbramley
Thanks for everyone's hard work getting this across the line, this will be included in the next beta
- ๐น๐ทTurkey makbay
Why would you ignore other people's contributions and haven't given credit to them?
- ๐ฆ๐บAustralia acbramley
@makbay bit rude, but I credited everyone that provided valuable testing or contributions to this issue.
If I've missed someone then please let me know and I'll update it. You opened 2 MRs and immediately closed them.
Automatically closed - issue fixed for 2 weeks with no activity.