Block page visibility paths are not validated, using path a without leading forward slash does not work

+++ b/core/modules/system/src/Plugin/Condition/RequestPath.php
@@ -112,6 +112,22 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta
+      else {

The else does nothing here, so let's drop it and the return for simplicity sake, less code++.

There's a new string here, so I think that makes this 10.1.x only, tagging as such

Removed else

This looks RTBC to me now, assuming the bot agrees

The last submitted patch, 57: 2843992-57.patch, failed testing. View results →

Random fail

Another random failure

Committed e47f5e7 and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

Was looking at this issue and not sure why larowlan and sonam and maybe one or two others didn't get issue credit... but it's closed now so :shrug: :)

I believe I didn't credit @sonam.chaturvedi because at the time of #55 there was already automated tests that verified that the message was triggered. I missed that there was a question in the comment which looking at it now probably should have been addressed. I opened a follow-up for that since I think it's a good suggestion for usability 📌 Validate all invalid paths in block visibility Active .

We usually give credit for non-trivial code reviews. It's hard to evaluate how substantial a review is but this time it looks like I decided that the feedback from @larowlan wouldn't qualify for the credit.

Thank you for the explanation. I’ll reassess how we decide to do manual testing in the future.

A contrib module called Block Exclude Pages was relying on the bug behavior.

💬 Drupal 10.1 + Rejecting paths not conforming to standard URL's set by Drupal Postponed: needs info