Numeric item min/max settings ignored if set to 0

Created on 20 December 2016, almost 8 years ago

Updated 24 November 2023, about 1 year ago

Problem/Motivation

PHP's empty() function is not enough to check for $settings['min'] or $settings['max'] for numeric item - \Drupal\Core\Field\Plugin\Field\FieldType\NumericItemBase::getConstraints(), because their value can be numeric zero, and in such case constraint is not returned.

This results in possible invalid numeric values for items that have min or max boundary set to 0.

Rough example:

Custom entity class, baseFieldDefinitions()

    $fields['hour'] = BaseFieldDefinition::create('integer')
      ->setLabel(new TranslatableMarkup('Hour'))
      ->setSetting('min', 0)
      ->setSetting('max', 23);

Custom code

  $e = CustomEntity::create([ 'hour' => -100 ]);
  $violations = $e->validate();

Validation passes w/o errors, because NumericItemBase::getConstraints() does not return constraint to check for minimum.

Proposed resolution

Replace !empty() check with check for non-empty string (because an empty string is default value of min/max settings):

if ($settings['min'] !== '') {}

🐛 Bug report

Status

Closed: duplicate

Version

11.0 🔥

Component

Field →

Last updated 2 days ago

Maintained by
🇷🇴Romania @amateescu

Created by

🇺🇦Ukraine pingwin4eg Zaporizhia 🇺🇦

Live updates comments and jobs are added and updated live.

DevDaysSeville

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Bug Smash Initiative

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Could someone confirm #3090629: NumericItemBase never sets minimum value constraint if minimum value is zero. → solves this issue?
Status changed to Closed: duplicate about 1 year ago7:01am 24 November 2023
Comment about 1 year ago →
🇳🇿New Zealand quietone
The issue summary at #3090629: NumericItemBase never sets minimum value constraint if minimum value is zero. → does look like it is solving the same problem and so does the code changes. I doubled checked and tested as well. I am closing this as a duplicate and moving credit over there.

Cheers

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024