- Merge request !5[#2836514] Add configurable notification email settings, then use them when sending mail. β (Closed) created by cafuego
- πΊπΈUnited States greggles Denver, Colorado, USA
This has a conflict now so needs a reroll. Marking needs work for that.
Thanks cafuego and others for the work on this so far.
- π¦πΊAustralia cafuego
Hateful gitlab won't let me push to the feature branch for reasons I cannot fathom.
- Status changed to Needs review
6 months ago 2:53am 23 July 2024 - π¦πΊAustralia cafuego
All the tests are green, so I guess now the only question is "does it still do what it is supposed to do" ;-)
- πΊπΈUnited States joegraduate Arizona, USA
Uploading latest MR diff as static patch file usable for composer.
- πΊπΈUnited States joegraduate Arizona, USA
We've tested the MR/patch with good results and are hoping this change will be committed soon as we'd like to use this module on several sites.
- πΊπΈUnited States joegraduate Arizona, USA
Most of the testing I've done with this patch was with the functionality for disabling email notifications. Taking a closer look at the functionality for customizing the notification email subject and message I see a potential config schema improvement that we may want to address before merging this.
I think we should replace the new
mail.subject
andmail.body
config settings with a single setting of themail
config schema type consistent with how the core user module mail configuration settings work.I also wonder if we need to include a database update function to apply the default mail config setting(s) to existing sites.
- Merge request !26Issue #2836514: Allow notification emails to be customized/disabled β (Closed) created by joegraduate
- First commit to issue fork.
- πΊπΈUnited States joegraduate Arizona, USA
Created a new MR targeting 2.x branch that includes rebased changes from original 8.x-1.x MR + the config schema changes and DB update described in #19.
- πΊπΈUnited States joegraduate Arizona, USA
joegraduate β changed the visibility of the branch user_expire-2836514/8.x-1.x to hidden.
- πΊπΈUnited States joegraduate Arizona, USA
joegraduate β changed the visibility of the branch 2855005-reset-expiry-on-reactivation to hidden.
- πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
I think the machine names for the settings should be more specific so they donβt exclude additional email/notification options, we can address the confusing label names in the config interface in π Review and improve form field labels and description Active
- πΊπΈUnited States joegraduate Arizona, USA
Made some more improvements to the new settings in the settings form and the overall implementation of when the warnings are sent. This ready for final review now IMHO.
- Merge request !38Issue #2836514: Allow expiration warning emails to be customized/disabled β (Merged) created by joegraduate
- πΊπΈUnited States joegraduate Arizona, USA
joegraduate β changed the visibility of the branch 2836514-2.x to hidden.
- πΊπΈUnited States joegraduate Arizona, USA
Created new branch from existing MR (duplicate MR) to trigger tugboat.
-
joegraduate β
committed 46dffaf9 on 2.x
Issue #2836514 by joegraduate, cafuego, ervan.salin, trackleft2,...
-
joegraduate β
committed 46dffaf9 on 2.x
- Status changed to Fixed
13 days ago 11:44pm 1 January 2025 Automatically closed - issue fixed for 2 weeks with no activity.