Contrib.social

Field rendered on revisions with translations enabled produce SQL errors

Open on Drupal.org →
Created on 4 December 2016, about 8 years ago
Updated 10 September 2024, 4 months ago

Problem/Motivation

Steps to reproduce

  • Enable more than two languages
  • Create a revision based view
  • Create a revision back to the view
  • Add the "content revision: title" field
  • You end up a with a SQL error

Proposed resolution

Problem

  • \Drupal\views\Entity\Render\TranslationLanguageRenderer::query calls to $storage->getTableMapping()->getFieldTableName($langcode_key) which at the moment returns the normal data table for revision views, so later views cannot find the right join, as the relationship defined above is explicit.
  • The solution is to make getFieldName revision aware as pass along whether we want to get revisions or not.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Closed: cannot reproduce

Version

11.0 🔥

Component
Views  →

Last updated 21 minutes ago

Created by

🇩🇪Germany dawehner

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇧🇾Belarus dewalt
  • Status changed to Closed: cannot reproduce 4 months ago
  • Comment 4 months ago →
    🇳🇿New Zealand quietone

    A maintainer asked for steps to reproduce 8 years ago and none have been supplied. There was a second request 2 years ago and again no reply.

    Since we need more information to move forward with this issue and it has not been supplied. I am closing this issue. If you are experiencing this problem on a supported version of Drupal reopen the issue, by setting the status to 'Active', and provide complete steps to reproduce the issue → (starting from "Install Drupal core").

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024