UserRouteProvider should extend DefaultHtmlRouteProvider

Open on Drupal.org →

Created on 10 October 2016, over 8 years ago

Updated 27 January 2023, about 2 years ago

Problem/Motivation

UserRouteProvider does not extend DefaultHtmlRouteProvider. Thus, it contains duplicated logic.

Proposed resolution

Make UserRouteProvider extend DefaultHtmlRouteProvider.

Remaining tasks

Review.

User interface changes

None.

API changes

If someone has a route provider that extends UserRouteProvider and has e.g. a getCanonicalRoute() with different parameters than DefaultHtmlRouteProvider this could break. I think that is something we can get away with in a minor version but I guess we could write a change notice to be nice.

Data model changes

None.

📌 Task

Status

Needs work

Version

10.1 ✨

Component

User system →

Last updated 1 day ago

Maintained by
🇺🇸United States @moshe weitzman
🇧🇪Belgium @kristiaanvandeneynde

Created by

🇩🇪Germany tstoeckler Essen, Germany

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 2 years ago →
🇮🇳India sahil.goyal
Reroll the patch for drupal 10.1.x and attaching the reroll diff where i was not sure with last patch sequence number, and make few more changes in the patch to fix php coding standard issues.
Comment about 2 years ago →
🇮🇳India pooja saraah Chennai
Fixed failed commands on #21
Attached patch against Drupal 10.1.x
Comment about 2 years ago →
🇬🇧United Kingdom longwave UK
#21 is failing PHPStan.

@catch's comments in #6 still apply. Following 📌 Support route aliasing (Symfony 5.4) and allow deprecating the route name Needs work we could deprecate user.admin_create and replace it with entity.user.add_form which would remove some of the code, but I'm still not sure it will be worth it.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024