The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 2 years ago 10:26am 9 February 2023 - Status changed to Needs work
about 2 years ago 11:07am 9 February 2023 - 🇮🇳India kkalashnikov Ghaziabad, India
@init90 thanks for reviewing. But can you please help me to understand that what is missed in this patch ?
- 🇺🇦Ukraine init90 Ukraine
@kkalashnikov, in the original patch in #15 hook documentation moved to the other place, your patch just delete documentation.
- 🇮🇳India kkalashnikov Ghaziabad, India
ohh yes it was missed in current patch thanks @init90.
This is the updated patch
- 🇮🇳India Akram Khan Cuttack, Odisha
fixed CCF #33 and some conding standard issues
- Status changed to Needs review
about 2 years ago 6:19am 10 February 2023 - Status changed to Needs work
about 2 years ago 2:01am 4 March 2023 - 🇺🇸United States smustgrave
Patch #34 appears to contain a lot of out of scope changes. Can look at the file size and see that.
- Status changed to Fixed
almost 2 years ago 5:04pm 20 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.