Provide screen-reader feedback when Views UI filterable options are updated

Reroll, plus #67 feedback, plus rename of the variable since this is used for more than just views filtering

No interdiff because of reroll.

Attempt at fixing the linting.

Also back to getting the number of expected values dynamically in the test, basically because of what I said in #61, the number can change and figuring out the right number is annoying.

I should really get linting to run at some point....

This came up for daily random #bugsmash triage, that's why @Lendude helpfully resurrected this and re-rolled to address the feedback. Thanks!

I wish we fixed #3122231: Singular variant for plural string must contain @count → so we stopped "doing it wrong" and all new code used @count for both the single and plural strings. Probably not worth holding this up to change it, so not setting NW. Close review of the code shows no other problems to complain about.

The bot is happy. There's new test coverage. The issue title and summary are clear. I don't believe this needs / wants a CR or release note, but at least tagging that it's a "String change".

RTBC!

Thanks again,
-Derek

Removing credit for #27, a 1-off re-roll with failing tests that the author never came back to help fix.

Adding credit to @BarisW, @mgifford and myself for helpful reviews.

I think that should be pretty close to accurate, but of course the committer will have the final say.

Thanks again, everyone!
-Derek

Adding tag for WCAG SC 3.2.7

The last submitted patch, 80: 2805197-80.patch, failed testing. View results →

Seems like a random fail to me:

Drupal\FunctionalTests\Installer\InstallerExistingConfigMultilingualTest
exception: [Other] Line 0 of sites/default/files/simpletest/phpunit-408.xml:
PHPUnit Test failed to complete; Error: PHPUnit 9.6.7 by Sebastian Bergmann and contributors.

Testing Drupal\FunctionalTests\Installer\InstallerExistingConfigMultilingualTest
E                                                                   1 / 1 (100%)

Time: 00:08.944, Memory: 4.00 MB

There was 1 error:

1) Drupal\FunctionalTests\Installer\InstallerExistingConfigMultilingualTest::testConfigSync
Exception: Drupal\language\Exception\DeleteDefaultLanguageException: Can not delete the default language
Drupal\language\Entity\ConfigurableLanguage::preDelete()() (Line: 177)

A few optimizations to do but this overall looks good.

1. +++ b/core/modules/views_ui/js/views-admin.js
   @@ -573,12 +574,23 @@
   +          }
   

   The unary operator converts boolean to integers 0/1, so this can be a single line
   activeItems += found

2. +++ b/core/modules/views_ui/tests/src/FunctionalJavascript/FilterOptionsTest.php
   @@ -66,6 +66,10 @@ public function testFilterOptionsAddFields() {
   +    $session->wait(10000, 'jQuery("#drupal-live-announce").html().indexOf("1 option is available in the modified list.") > -1');
   +    $web_assert->elementTextContains('css', '#drupal-live-announce', '1 option is available in the modified list.');
   

   These two lines can be consolidated by using waitForElementTextContains() see WidgetUploadTest in Media Library

3. +++ b/core/modules/views_ui/tests/src/FunctionalJavascript/FilterOptionsTest.php
   @@ -81,6 +85,14 @@ public function testFilterOptionsAddFields() {
   +    $session->wait(10000, 'jQuery("#drupal-live-announce").html().indexOf("' . $block_row_count . ' options are available") > -1');
   +    $web_assert->elementTextContains('css', '#drupal-live-announce', $block_row_count . ' options are available in the modified list.');
   

   These two lines can be consolidated by using waitForElementTextContains() see WidgetUploadTest in Media Library