In Drupal\Core\Template\TwigNodeTrans constructor, \Twig_Node $plural, \Twig_Node_Expression $count and \Twig_Node_Expression $options parameters are null as default value, but next parameter $lineno is required.
public function __construct(\Twig_Node $body, \Twig_Node $plural = NULL, \Twig_Node_Expression $count = NULL, \Twig_Node_Expression $options = NULL, $lineno, $tag = NULL) {
// ...
}
As $lineno is required, $previous parameters are always setted.
As $previous is required, default value before this parameter can safely be removed.
public function __construct(\Twig_Node $body, \Twig_Node $plural, \Twig_Node_Expression $count, \Twig_Node_Expression $options, $lineno, $tag = NULL) {
// ...
}
Needs work
10.1 ✨
Last updated
Very small and simple change. Preferred over Quickfix.
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Since we changing the constructor believe we will need a change record to announce that the parameter can now be NULL.
Won't tag for it but maybe a test case showing what happens when you pass null in what happens.