Contrib.social

Extend test coverage for comment links weight to classy theme

Open on Drupal.org →
Created on 30 August 2016, almost 9 years ago
Updated 8 August 2025, 15 days ago

Problem/Motivation

From #2428509-41: Comment links weight should be managed by view display →

I'm also not sure what the test here is really doing, the test doesn't seem to be testing Bartik (it's testing Stark) and Bartik is the only functional (non-test) code we're changing. Am I missing something? I'm not against adding test coverage but if there's similar coverage elsewhere then I don't think we should add it on account of this issue. I ran the test locally and it passes both with and without the functional part of the patch.

Should the component be Bartik for this?

Proposed resolution

Test all bartik and classy themes with comment link weight changes

Remaining tasks

Extend tests

User interface changes

no

API changes

no

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

comment.module

Created by

🇫🇷France andypost

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 15 days ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024