Add skip-method option to file_copy and download process plugins

Open on Drupal.org →

Created on 14 July 2016, over 8 years ago

Updated 13 May 2024, 8 months ago

The file_copy process plugin being added in #2695297: Refactor EntityFile and use process plugins instead → throws MigrateException when a copy fails, aborting the entire row being processed. This makes sense for the core usages in d6_file and d7_file, where it makes no sense to create the file entity if the file itself does not exist in Drupal. However, in contrib we'd like to use this plugin in other contexts - in particular, to copy a file and create a file entity within a file/image field mapping in a node migration ( #2635622: Process plugin for importing/creating files by URL → ). In this case, we don't want to throw out the node for the sake of a missing file, we just want to leave the field empty.

To support this, let's add a skip_process_on_failure option - when set to TRUE, we'll throw MigrateSkipProcessException instead of MigrateException.

✨ Feature request

Status

Needs work

Version

11.0 🔥

Component

Last updated about 13 hours ago

Maintained by
🇺🇸United States @benjifisher
@heddn
🇺🇸United States @mikelutz
🇳🇿New Zealand @quietone

Created by

🇺🇸United States mikeryan Murphysboro, IL, USA

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & sqlite-3.34
18:51
18:37
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update about 1 year ago
Composer error. Unable to continue.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
18:51
18:37
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
18:51
18:37
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & pgsql-14.1
17:58
16:35
Running
Comment 12 months ago →
🇩🇪Germany donquixote
@mikelutz (#18)
For the record.

This is supposed to be a MigrateSkipProcessException, not a MigrateSkipRowException.
MigrateSkipRowException has the same effect as MigrateException

The difference is that with MigrateSkipRowException, the migration still counts as "successful" for the sake of dependent migrations.
With MigrateException, the entire migration counts as failed, which blocks dependent translations.
Comment 8 months ago →
🇺🇸United States joegraduate Arizona, USA
Re-rolled #33 against latest 11.x

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024