The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- πΊπΈUnited States jhedstrom Portland, OR
The HAL module has been removed from core, so moving this to the new contrib project.
- π«π·France Grimreaper France π«π·
I don't think this is the correct contrib project of the HAL module.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
+++ b/core/modules/hal/src/Normalizer/EntityReferenceItemNormalizer.php @@ -80,8 +80,15 @@ public function normalize($field_item, $format = NULL, array $context = []) { + else {
we don't need this else, as we returned above
Still needs work for task 2 in the issue summary
- last update
over 1 year ago 694 pass, 3 fail - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Looks like we need to update tests to allow for the block content path changes in core in 10.1
- last update
over 1 year ago Composer require failure - last update
over 1 year ago 706 pass - last update
over 1 year ago 706 pass - last update
over 1 year ago Composer require-dev failure - last update
over 1 year ago Composer require-dev failure - π¨π¦Canada joseph.olstad
@larowlan, you are likely correct.
I just checked D10
A custom block edit path looks like this:
/block/99
Have to look closer at the above tests, hope this helps
- last update
over 1 year ago Composer require-dev failure - last update
over 1 year ago Composer require-dev failure - last update
over 1 year ago 694 pass, 3 fail - last update
over 1 year ago 706 pass - last update
over 1 year ago 706 pass - last update
over 1 year ago 706 pass