Contextual Links do not respect parameters in the destination

Attempted to address #39

I considered nit-picking that we could use the second argument to parse_url in the test, but realised it was the definition of yak shaving

The last submitted patch, 40: 2738547-40.patch, failed testing. View results →

Random failure

Requeued the test job (we should always do that when something hits a known random, not just set it back from NW).

Committed 4a0272e and pushed to 10.1.x and cherry-picked to 10.0.x. Thanks!

Sending the 9.5.x patch to the test bot.

I remember this issue … 👴 Great to see it fixed!

Committed 5ca9f5d and pushed to 9.5.x. Thanks!

Reviewing this issue. I'm not sure why DeepaliJ wasn't credited as no one had tested the patch beforehand but this issue is closed so I assume it won't be changed.

I didn't credit @DeepaliJ because at that time, the patch is making one change to the contextual links which already has automated test coverage in the change being proposed. There also had been manual testing for the same change prior to the automated tests being added by @sahil.goyal, all that was changed since then was that automated tests were added.

Thank you for the explanation. I think that people who do QA wouldn’t realize it didn’t need testing. There was a new patch and no one explained it didn’t need testing. I wish we had a better process so people don’t waste time on things that aren’t needed.