[PP-1] NodeRouteProvider should extend DefaultHtmlRouteProvider

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Did my best to reroll #94 onto 11.x but the deprecation stuff is a bit new to me. It all changed in #3272779: [Symfony 6.1] Replace deprecationListenerTrait with PHPUnitBridge ignoreFile → so hopefully I've done it right.

This needed a rebase, which I did, and then updated the deprecation messages. That should help the Kernel tests to pass. I ran ManageFieldsFunctionalTest::testHelpDescriptions locally and it failed with access denied.

The problem was the requirements on the routes, which were keys which didn't exist any more -- probably from an older version of this MR, referring to requirements handlers which have been removed since.

( ✨ add a way to manually use the test site from a Functional test Needs review was useful here for debugging!)

Oh yes -- should we move most of core/modules/node/src/RouteProcessor/NodeDeprecatedRouteProcessor.php to a common class and leave just the $routeMap & the deprecation message in that class, so it can be reused in future route deprecations?

I think it would be better if we do this after 📌 Support route aliasing (Symfony 5.4) and allow deprecating the route name Needs work , with the benefit of having a lot less BC code and test coverage to maintain.