Fix Drupal.Commenting.FunctionComment.ParamCommentFullStop

Revisiting this with the idea of enabling and adding 'phpcs:ignore' to ignore problems with the sniff. This was done else where with the variable naming sniff, so there is precedent. If agreed to a followup is needed to remove the ignore lines when Coder has made changes.

Right now, I think doing this makes sense. It is a bit annoying to add the ignore lines but a link in an @see is not common. There are less that 10 of them.

Left some comments on the MR.

I have tried to address the added feedback, but I have two points to discuss:

Single Quotes: If we use single quotes, I have reviewed the entire MR and found additional places where updates are needed. Should we update all occurrences for consistency?
Full Stop in Keys: I have reviewed the MR and noticed the same behaviour for adding a full stop in keys.

Please review and let me know. Thanks

Needs a rebase

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

Rebased and responded to comments in the MR.

@shalini_jha, there isn't a strict standard for the type of quotes. So, we usually defer to what is done in a particular file, so at least the file is consistent. The only place I found where quotes are mentioned is in Making lists in documentation → . Hope that helps.

@quietone Thank you so much for the clear explanation! I have gone through the documentation, and it makes sense. I truly appreciate your guidance :)

  *   - "create".
   *   - "update".
   *   - "delete".

We sure this is an improvement? Seems odd to have periods after a single word.

My searching about how to punctuate lists, which was weeks ago, didn't come up with a definitive answer. Although having full stops at the end of single words wasn't usually an option. So,yes, it may appear odd. I lean to thinking it is better to have some odd or unusual cases while gaining the benefit of fixing, and preventing, future errors.

Fair enough

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The question about quotes resulted in doing a bit of research. I commented on the MR and updated the IS with the result.

Believe feedback on this one has been addressed

nod_ → closed merge request !494

Committed e990205 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.