\Drupal\Core\Url does not accept root-relative (file) URLs, making it impossible to let LinkGenerator create root-relative file URL links

Created on 8 January 2016, over 8 years ago

Updated 27 November 2023, 10 months ago

Problem/Motivation

Examples:

template_preprocess_file_link()
\Drupal\file\Plugin\Field\FieldFormatter\BaseFieldFileFormatterBase::viewElements()
\Drupal\file\Plugin\Field\FieldFormatter\FileUriFormatter::viewValue()
…

These all generate links (<a href="…"></a>) using LinkGenerator/\Drupal\Core\Link, which in turn require \Drupal\Core\Url objects.

Those \Drupal\Core\Url objects require a URL scheme. Which means root-relative (file) URLs cannot be passed to them, which means we must generate absolute file URLs, which means trouble as soon as you encounter sites available over both HTTP and HTTPS.

Proposed resolution

Detect root-relative URLs, automatically use the base: scheme. This is then similar to what \Drupal\Core\Url::fromUri() already does for protocol-relative URLs.

Remaining tasks

None.

User interface changes

None.

API changes

No changes; one addition: Url::fromUri() no longer considers /cat.png invalid (i.e. as using an invalid URI scheme); instead it detects this as a root-relative URL and hence uses the base: scheme.

Data model changes

None.

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Routing →

Last updated 1 day ago

Maintained by
🇺🇸United States @tim.plunkett

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.

https

Triaged core major
There is consensus among core maintainers that this is a major issue. Only core committers should add this tag.

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇫🇷France andypost
parented to 🌱 [meta] Use FileUrlGenerator::generate() everywhere, then deprecate generateString() and generateAbsoluteString() Active

hiding all patches as useless
First commit to issue fork.
Status changed to Needs review 10 months ago12:27pm 27 November 2023
Comment 10 months ago →
🇫🇮Finland jennakoo
Rerolled the patch for Drupal 10.1
Comment 10 months ago →
🇫🇷France andypost
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 10 months ago
Custom Commands Failed
Status changed to Needs work 10 months ago3:27pm 27 November 2023
Comment 10 months ago →
🇺🇸United States smustgrave
Think this needs an issue summary update, reading comment 51-53 @berdir makes it sound like this patch shouldn't be needed anymore.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024