Route normalizer: Global Redirect in core

Open on Drupal.org →

Created on 27 December 2015, almost 9 years ago

Updated 27 October 2023, about 1 year ago

Problem/Motivation

Originally, some work was started in 🐛 Browser language detection is not cache aware Needs work to resolve a caching issue. A language redirect was introduced, but the implementation was more general than just adding the language prefix. The target redirect URL was constructed from current route. This caused some test fails (especially, in case if this redirect is enabled always even if the language module is not installed, see 2430335#89 → ). And this issue was created.

Current implementation

There is a new route_normalizer_request_subscriber service that perform redirects like the Global Redirect → module. On a GET request, it construct a URL from the current route and the current route/query parameters, and redirects to that URL if it does not match the incoming URL. This causes:
- language redirect, for example from "/" to "/en", this resolves 🐛 Browser language detection is not cache aware Needs work
- path alias redirect, for example from "node/1" to "content/my-node"
- front page redirect, for example from "/node" to "/"
There can be more cases, but they are unknown at the moment.

Also, the patch contains some fixes for bugs caught during development, and some documentation changes.

Arguments for this feature:
- globalredirect has a lot of installations, people might need this feature in the core
- better SEO
- less cache entries
- it allows to catch bugs at early development stage (check the fixes provided in the patch)

Remaining tasks

- fix remaining test fails
+ write tests
- try to use CacheableRedirectResponse

User interface changes

The default Drupal installation will behave like the one having the Global Redirect → module enabled.

API changes

The "disable_route_normalizer" request attribute can be set to disable the route normalization:

$request->attributes->set('disable_route_normalizer', TRUE);

Data model changes

none

✨ Feature request

Status

Needs work

Version

11.0 🔥

Component

Request processing →

Last updated 7 days ago

No maintainer

Created by

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Merge Requests

!10285Route normalizer: Global Redirect in core
Open
🇷🇴Romania amateescu
updated 27 days ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 year ago →
🇩🇰Denmark ressa Copenhagen
Getting Redirect → and ✨ Pathauto in Core Needs work would be awesome, as well as Token → (is there an issue for this?), since these three modules are probably installed in most Drupal sites.
Comment about 1 year ago →
🇳🇱Netherlands spokje
Comment about 1 year ago →
🇳🇱Netherlands spokje
First commit to issue fork.
Merge request !10285Add two redirect subscribers. → (Open) created by amateescu
Comment about 1 month ago →
🇷🇴Romania amateescu
Re #170.1:

I think we need to check whether this causes a regression for those requests (which should be the majority of requests on most sites).

Yes, this definitely causes a regression, see this issue in the Redirect module: 🐛 Feature or Bug? - The path-alias preloading is not used if the "Enforce clean and canonical URLs" option is enabled Active

I've started a MR with a fresh approach based on the suggestions from #171: let 🐛 Browser language detection is not cache aware Needs work deal with language detection, and only handle front page and path alias redirects in this issue.

Setting to NR for architectural review, please don't change it to NW because of missing test coverage :)
Pipeline finished with Failed
about 1 month ago
Total: 4648s
#345676

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024