Cannot edit actions created by user_user_role_insert()

Created on 30 October 2015, about 9 years ago
Updated 22 April 2024, 8 months ago

Problem/Motivation

If I create a role and have the Actions module enabled I can edit the role created by user_user_role_insert() - but I can not save. This is because the ID has a dot in it.

Proposed resolution

There are currently three proposals:

  1. Allow actions to have dots in their config names (as is true of entity_view_mode, entity_form_mode, block, and config_test)
  2. Change user_user_role_insert to not create actions with dots
  3. Add a UI lock on actions, and lock those created via user_user_role_insert (similar to date_format).

#3 might be appropriate since these actions are created and deleted by the User module. In fact the user_user_role_delete is completely unnecessary because of configuration dependencies. So therefore it could be possible to remove that and just create an action with an ID that can be edited.

However this is related to a wider issue of should configuration entities be able to control the meaning of dots in their ID see #2100203: Make config entities use dots in machine names consistently β†’

Remaining tasks

Agree approach

User interface changes

tbd

API changes

tbd

Data model changes

tbd

Why is this a possible RC target

The UI makes it look like such actions are editable but they are not. We have a form where the submit is impossible - regardless of what the user does.

πŸ› Bug report
Status

Needs work

Version

11.0 πŸ”₯

Component
User moduleΒ  β†’

Last updated 2 minutes ago

Created by

πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

  • Triaged core major

    There is consensus among core maintainers that this is a major issue. Only core committers should add this tag.

  • Needs change record

    A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024