There is no render #thingie the behaves like twig.
This means that issues like #2567159: Fix improper usage of t() in ViewsBlock → are resorting to inline templates to get this behaviour. Funnily enough we use to be able to flip #markup between filtering and escaping but that got changed in #2555931: Add #plain_text to escape text in render arrays → . I think the rationale behind that change was good since
$render_array = ['#plain_text' => SafeString::create('<em>I win</em>')];
looks awful.
But
$render_array = ['#plain_text' => t('@thing: @subthing', $placeholders)];
the fact that this will double escape is also awful.
Not sure. We could make #plain_text use the inbuilt double escaping prevention in htmlspecialchars() or maybe once t() and SafeMarkup::format return objects we could glean information as to how they are made safe.
Needs work
11.0 🔥
Last updated
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.
The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Wonder if the issue summary could be updated though.
The proposed solution, correct me if I'm wrong, doesn't seem to match up with the solution in the patch.
Solution wise though this looks good.
This was triaged as part of BSI. At the very least needs a reroll onto an MR.