- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Adding some tags
Removing needs tests because I don't think we need them here, testing will be arduous
- Status changed to Needs review
about 2 years ago 4:18am 23 February 2023 - Status changed to Needs work
about 2 years ago 7:47am 23 February 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India karishmaamin
Sorry, there was Custom command failure #37. Here is the patch fixing that
- Status changed to Needs review
about 2 years ago 6:10am 27 February 2023 - 🇮🇳India Aadhar_Gupta
I applied the #39 patch on my local and it got applied but somehow I missed that part and applied php-cs and php-cbf there was a minor change so I created an interdiff and uploaded the patch so this patch can be considered as improved code quality.
- Status changed to RTBC
about 2 years ago 1:01pm 27 February 2023 - 🇮🇳India Ranjit1032002
I had Reviewed the patch and it's working as expected mentioned in comment #40
- Status changed to Needs work
about 2 years ago 6:09am 20 March 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
+++ b/core/modules/locale/locale.bulk.inc @@ -467,7 +473,7 @@ function locale_translate_file_attach_properties($file, array $options = []) { - // {project}-{version}.{langcode}.po, {prefix}.{langcode}.po or {langcode}.po + // {project}-{version}.{langcode}.po, {prefix}.{langcode}.po or {langcode}.po.This change is out of scope
- Status changed to RTBC
about 2 years ago 7:48am 20 March 2023 - Status changed to Needs work
about 2 years ago 7:15am 29 March 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Can we trace down when the URL param was removed? The original issue summary says there was originally a link but it wasn't in the string.
i.e. I think the original issue has been resolved and I'm not sure we're gaining much with the current patch.
It looks to me like the original issue was fixed in #2062103: Skipped translation import shows dblog link message that is not yet available in installer → - so either we need an issue summary update with the new intent or we can close this as duplicate.
Please advise.
