UpdatePathTestBase saves the root user before updates have run

Updated it for D10

Since it's a task does it still need a test?

Tried to fix CCF for #26.

The last submitted patch, 27: 2560237-27.patch, failed testing. View results →

Tried to fix the phpunit errors by replacing the deprecated method getUsername() with getAccountName().

Thanks!

Thanks @ankithashetty and good find!

The last submitted patch, 29: 2560237-29.patch, failed testing. View results →

Random ckeditor5

+++ b/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php
@@ -298,14 +297,14 @@ protected function runDbTasks() {
   protected function replaceUser1() {
-    /** @var \Drupal\user\UserInterface $account */
-    // @todo Saving the account before the update is problematic.
-    //   https://www.drupal.org/node/2560237
-    $account = User::load(1);
-    $account->setPassword($this->rootUser->pass_raw);
-    $account->setEmail($this->rootUser->getEmail());
-    $account->setUsername($this->rootUser->getAccountName());
-    $account->save();
+    Database::getConnection()->update('users_field_data')
+      ->fields([
+        'name' => $this->rootUser->getAccountName(),
+        'pass' => \Drupal::service('password')->hash($this->rootUser->pass_raw),
+        'mail' => $this->rootUser->getEmail(),
+      ])
+      ->condition('uid', 1)
+      ->execute();

I think we could do with a comment to explain why we're doing it like this - so no one thinks this is a good idea to copy and to put into real run-time code.

Reroll of #29 and added comment as suggested in #33.

Can issue summary be cleaned up some. Appears to have 2 solutions but not highlighted which.

Updated IS. Setting NR.

Looks ready to me!

This is a blocker for 🐛 entity.last_installed_schema.repository has a race condition Needs review .

Left one suggestion on the MR.

Committed and pushed 8b53ceb644 to 11.x and a113593f22 to 10.4.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.