- 🇳🇿New Zealand quietone
Closing as a duplicate of 📌 [meta] Remove usage of t() in tests not testing translation Active and moving credit.
- 🇳🇿New Zealand quietone
I think I should not have closed this. I was probably focused on t() at the time but today I see uses of FormattableMarkup in tests where it could be removed. And I guess I didn't read #74.
Sorry folks.
- Status changed to Active
22 days ago 8:50am 30 November 2024 - 🇷🇺Russia zniki.ru
Thanks everyone for your effort.
It looks like title and summary are different, as already mentioned at #51, and it's extremely difficult to understand what is happening here/
As I understand original issue was "Remove all usage of SafeMarkup::format() and format_string() in tests apart from explicit tests of those methods".I checked patch #78, at the top we remove t() function.
My suggestion:
revert issue title to original value and close this issue, and create new one with focus to remove FormattableMarkup.In order to provide code contribution is better to use child issue #3227598: Remove uses of FormattableMarkup in kernel test assertions → .