Contrib.social

You can add a review, opinion, greeting, etc. comment type but not change the "Add new comment" text

Open on Drupal.org →
Created on 5 August 2015, over 9 years ago
Updated 5 May 2023, over 1 year ago

Problem/Motivation

Follow-up to #2228763: Create a comment-type config entity and use that as comment bundles, require selection in field settings form → . At the moment the comment form heading always says "Add new comment" on the form. If you have a specific comment type like "Greeting" you probably want it to say "Write greeting" instead.

Proposed resolution

Provide settings on the comment type config entity, similar to "Submission form settings" for content types where you can configure the form heading (defaults to "Add new comment"). The "Comments" label is taken from and can already be modified in the field settings.

Remaining tasks

Adopt the existing patch from #25 based on comments from #41:

  • needs hook_update_n() implementation to update all existing comment types
  • get rid of entity loading in preprocess
  • $this-t() should be used in forms
  • there's no reason for empty() check for default_value

User interface changes

New setting on the field.

API changes

Likely none. Config schema is expanded.

Data model changes

Config is expanded.

📌 Task
Status

Needs work

Version

10.1 ✨

Component
Comment  →

Last updated 12 days ago

Created by

🇭🇺Hungary Gábor Hojtsy Hungary

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland

    Usability review was provided in comment #104, removing tag.

  • Comment 12 months ago →
    🇺🇸United States cedewey Denver, CO

    I've updated the task description based on the UX committee's recommendations.

    As the Comment Module's maintainers, @larowlan or @andypost can you review the proposed resolution and state whether you approve of the proposed resolution? And if not, list out your concerns and ideally an alternative proposal?

  • Comment 12 months ago →
    🇺🇸United States cedewey Denver, CO
  • First commit to issue fork.
  • Merge request !922511.x → (Open) created by jacobupal
  • Pipeline finished with Failed
    4 months ago
    Total: 310s
    #255378
  • Pipeline finished with Canceled
    4 months ago
    Total: 192s
    #255381
  • Pipeline finished with Failed
    4 months ago
    Total: 129s
    #255382
  • Pipeline finished with Failed
    4 months ago
    Total: 124s
    #255383
  • Pipeline finished with Failed
    4 months ago
    Total: 552s
    #255384
  • Comment 4 months ago →
    🇫🇷France andypost
  • Pipeline finished with Failed
    about 1 month ago
    Total: 153s
    #337998
  • Comment about 1 month ago →
    🇬🇧United Kingdom jacobupal Leeds

    Updated the issue branch to make it merge-able again since conflicts arising from https://www.drupal.org/project/drupal/issues/3396165 📌 [meta] Convert all core plugin types to attribute discovery Active

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024