- last update
9 months ago 30,771 pass - Merge request !5985Stop using getMainRequest() to build form action #2505339 β (Open) created by andypost
- Status changed to Needs review
8 months ago 3:11pm 31 December 2023 - Status changed to Needs work
8 months ago 11:21pm 1 January 2024 - First commit to issue fork.
- Status changed to Needs review
8 months ago 9:34am 2 January 2024 - Status changed to RTBC
8 months ago 11:20am 2 January 2024 - π§πͺBelgium BramDriesen Belgium π§πͺ
Code wise this looks good! All tests are passing π
Also updated the readability of the CR a little bit. Not really sure if the CR needs more info or not.
I think we can set this to RTBC now.
- Status changed to Needs work
7 months ago 3:59pm 17 February 2024 - π¬π§United Kingdom longwave UK
I still don't think @alexpott or @dawehner's comments from #51 and #52 have been addressed. The CR doesn't really explain why you might be affected by this nor what you should do if you are, and the test coverage is very specific to the fix; it doesn't really prove anything about the original problem.