hook_page_(attachments|attachments_alter|top|bottom)() should specify the right cacheability metadata

Created on 27 April 2015, over 9 years ago
Updated 25 August 2023, about 1 year ago

Quoting Wim Leers in #2475749-2: Allow to set #cache metadata in hook_page_attachments() β†’ :

In a follow-up, we should make all hook_page_attachments(), hook_page_attachments_alter(), hook_page_top() and hook_page_bottom() implementations set the right cacheability metadata.

For example, quickedit_page_attachments() only adds its asset library if the current user has the right permission (vary by the 'user.permissions' cache context) and it's not an admin route (no cache context for that yet).

πŸ“Œ Task
Status

Needs work

Version

11.0 πŸ”₯

Component
BaseΒ  β†’

Last updated about 1 hour ago

Created by

πŸ‡§πŸ‡ͺBelgium wim leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024