Let config entity methods be tested on ViewUI

Created on 23 January 2015, almost 10 years ago
Updated 28 April 2023, over 1 year ago

Problem/Motivation

From #2341357-79: Views entity area config is not deployable and missing dependencies point 9. Per @dawehner, rather than skipping these methods in ViewUI test, they should just be wrappers to the same methods on the storage.

Proposed resolution

Have ViewUI's methods return the results from the storage instead of NULL, and stop skipping them in the unit test.

Beta phase evaluation

<!--Uncomment the relevant rows for the issue. -->

Remaining tasks

NR.

User interface changes

None.

API changes

None.

📌 Task
Status

Needs work

Version

10.1

Component
Views UI 

Last updated 13 days ago

Created by

🇺🇸United States xjm

Live updates comments and jobs are added and updated live.
  • VDC

    Related to the Views in Drupal Core initiative.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

  • 🇮🇳India nikhil_110

    Attached patch against Drupal 10.1.x

    Patch #22 is not applied for Drupal 10.1.x so Inter-diff file is not added.

    Checking patch core/modules/views_ui/src/ViewUI.php...
    error: while searching for:
        'reorder-displays' => '\Drupal\views_ui\Form\Ajax\ReorderDisplays',
      ];
    
      /**
       * Whether the config is being created, updated or deleted through the
       * import process.
       *
       * @var bool
       */
      private $isSyncing = FALSE;
    
      /**
       * Whether the config is being deleted through the uninstall process.
       *
       * @var bool
       */
      private $isUninstalling = FALSE;
    
      /**
       * The entity type.
       */
    
    error: patch failed: core/modules/views_ui/src/ViewUI.php:120
    error: core/modules/views_ui/src/ViewUI.php: patch does not apply
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    Custom Commands Failed
Production build 0.71.5 2024