- 🇧🇷Brazil joaopauloc.dev
Patch #31 was applied and works fine.
See all attachments for evidence.Hey@xjm, I updated this issue to reviewed and tested by the community status, after @bojhan comment on #21.
Should we keep this status or do we need to wait for another approval?
Thanks. - Status changed to Needs work
almost 2 years ago 11:06pm 6 February 2023 The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Assigned to joaopauloc.dev
- 🇧🇷Brazil joaopauloc.dev
On it, fixing the php cs and adding unit test to new widget created
- @joaopaulocdev opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 3:57pm 13 February 2023 - Status changed to Needs work
almost 2 years ago 11:57pm 3 March 2023 - 🇺🇸United States smustgrave
This still needs a usability review but just from my observations
There is no way to tell the current value.
When I saved this page the view mode said the value was 66 but I had 0 idea. - Assigned to camchandler98
- 🇺🇸United States camchandler98
I thought adding a display for the slider would be just quickly editing the twig template but boy was I wrong. Long story short I ended up twig debugging and saw that the range input is still using the default input template . I think I know what to do now though so I will work on it.