#2238217: Introduce a RouteMatch class → removed the getActiveTheme() method. Granted, not much was using it, but that is changing (two patches in the queue were using it and broke).
Now instead of calling that method, a properly injected class also has to inject a RouteMatch and pass it along. All I want is the current theme, I should be able to ask the theme negotiator for that.
In addition to all of the other classes implementing ThemeNegotiatorInterface, ThemeNegotiator is the one acting as the service, and has the extra methods to gather and delegate. This is similar to BreadcrumbManager, which implements BreadcrumbBuilderInterface.
Remove the RouteMatch parameter from determineActiveTheme(), so it serves as a replacement for getActiveTheme().
Inject RouteMatch into any theme negotiators that need it via their service definition.
Additionally, add a new interface for the addNegotiator() method that only ThemeNegotiator (the service class) implements.
N/A
N/A
ThemeNegotiatorInterface::determineActiveTheme() no longer takes any parameters.
Theme negotiators that need a route match should inject it via their service definition.
Needs work
11.0 🔥
Last updated
Enhances developer experience.
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
> I'm quite confused as the title doesn't match the actual patch at all!
I'm seeing several approaches in patches. Tagging for this.
This also seems to be potentially at odds with 📌 Just load the theme negotiators which are needed Needs work , which says:
> Convert \Drupal\Core\Theme\ThemeNegotiatorInterface::applies to accept a route object