Apply formatters and widgets to Comment base fields

Created on 27 March 2014, over 10 years ago
Updated 3 February 2023, over 1 year ago

As discussed in #2010930: [META] Apply formatters and widgets to rendered entity base fields (all besides node.title) β†’ it is policy to make rendered base fields throughout core configurable through the "Manage form display" UI.

In the case of the comments module, this will take care of many frequently-asked feature requests. This issue is about the Comment entity type's uid, name, mail, homepage and created fields.

#2578741: Add setting for size to email widget β†’ was spun off half way through as a dependency of this issue and is already committed.

Making the same change for "Manage display" is being handled in a separate issue #3090187: Mechanism to disable preprocessing of base fields in comment entity type so they can be configured via the field UI β†’ .

Remaining tasks

  1. Rework patch to use, and remove any overlap with, #2578741: Add setting for size to email widget β†’
  2. Fix test failures.
  3. Respond to code reviews #105,#106#108
  4. Create upgrade path & upgrade path tests
  5. ?"Once test failures are fixed, look into converting more base fields." (may no longer be relevant?)

User interface changes

None.

API changes

None. The comment.subject, comment.mail and comment.homepage base fields are rendered using widgets and formatters, and is no longer exposed as an "extra field".

πŸ“Œ Task
Status

Needs work

Version

10.1 ✨

Component
CommentΒ  β†’

Last updated about 12 hours ago

Created by

πŸ‡§πŸ‡ͺBelgium Wim Leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Seems to be having failures going back to #148

    Also was previously tagged for upgrade path and upgrade test which still need to happen

    Did not test issue.

Production build 0.69.0 2024