Comment::urlInfo no longer includes the comment-{cid} fragment

Created on 17 February 2014, over 10 years ago
Updated 27 February 2023, over 1 year ago

Updated: Comment #N

Problem/Motivation

Previously comment_uri() added the fragment comment-{cid} to the url so that the page jumped straight to the comment.
Comment::urlInfo() doesn't add this fragment, whilst porting Token to Drupal 8 we noticed the regression

Proposed resolution

Add the fragment back in Comment::urlInfo()

Remaining tasks

Review
Make tests pass if applicable

User interface changes

None

API changes

None

🐛 Bug report
Status

Needs work

Version

10.1

Component
Comment 

Last updated 2 days ago

Created by

🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

Live updates comments and jobs are added and updated live.
  • Needs reroll

    The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024