- 🇮🇪Ireland markconroy
@smustgrave in that case, I think this patch looks good.
@mgifford you added the WCAG412 issue. Is there any thing we need to consider here for that, or are you okay with this patch?
I'm going to ask a Claro maintainer to have a look at this as well, as I don't want us to change their markup with them knowing about it.
- 🇩🇪Germany rkoller Nürnberg, Germany
I've quickly tested the patch in #32 with voiceover in macos 12.6.1 and safari 16.1 and the latest edge and firefox.
I've first tested to tab through the page with the tab key (see macos_voiceover_tab.mp4). problem here is that the description is unnoticed in case you dont know that it is there. if you are opening up the rotor the period at the end of the sentence is inconsistent with the other links in the rotor. safari, edge and firefox behave the same.
I've then tested to use the virtual cursor (arrow up and down) to go through the page (see macos_voiceover_tab.mp4). that way i am able to getting aware of the description. the only odd thing is that voiceover is announcing styling informations like bold, italic, blue and alike which is distracting and at the same time you have not one element announced for example for the article link element but three text elements inside the wrapping link element. first
add
then the link title then theperiod
. and the virtual cursor only works in safari, in edge and firefox it has no effect at all.I wonder for one if it would make sense to remove the visually-hidden span at the end with the period in it (when tabbing it isn't announced, in the rotor it is inconsistent with the other links and with the virtual cursor it isn't adding any additional value just an extra announced text element inside of a link)?
and would it be an idea to add anaria-describedby
to the links? in case the user is tabbing through the list of available content types to add the associated description would be announced automatically. i've manually added anaria-describedby
attribute to the article content type in dev tools. it is announced correctly when tabbing through the page but it has to be noted for the virtual cursor if the user gets to the first link with the content type title the description isn't announced like with tabbing nor for any of the other text elements of the link. the description is announced afterwards when the user gets to it with the virtual cursor. so there wouldn't be any redundant information. - 🇨🇦Canada mgifford Ottawa, Ontario
@markconroy nothing needs to be changed based on what I tagged. This was just for the ability to sort/organize the issues.
- Status changed to Needs work
almost 2 years ago 4:08pm 23 January 2023 - 🇺🇸United States smustgrave
Tagging for tests also. But sounds like we are still working around the fix.