BookOutlineStorage don't use queries

Created on 24 July 2012, about 12 years ago
Updated 5 September 2024, 2 days ago

Problem/Motivation

There are queries in BookOutlineStorage, returning node IDs among other information, that do not invoke node access checks. This is on purpose, since the node access checks are done in other ways. But it needs to be noted in their documentation.

Proposed resolution

These methods need a note about checking the results with EntityInterface::access() (see e.g. #2847687: Improve test coverage for EntityAccessCheck β†’ ).

Remaining tasks

Move the documentation to the interface, for those methods that are not checking access.
Review
Commit

User interface changes

None.

API changes

None.

Data model changes

None.

πŸ“Œ Task
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States jhodgdon Spokane, WA, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024