- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 10:53pm 24 October 2023 - ๐จ๐ฆCanada mgifford Ottawa, Ontario
Wanted to flag this the accessibility concerns about properly labelling it:
In most cases you should provide an accessible label when using
<progress>
. While you can use the standard ARIA labelling attributes aria-labelledby or aria-label as you would for any element with role="progressbar", when using<progress>
you can alternatively use the<label>
element.I would say that using
<label>
is better.<label> Uploading Document: <progress value="70" max="100">70 %</progress> </label>
More good examples here - https://scottaohara.github.io/a11y_styled_form_controls/src/progress-bar/
- Status changed to Needs work
about 1 year ago 2:20am 28 October 2023 - ๐บ๐ธUnited States smustgrave
But think original question, least how I understood, is that this is definitely a good replacement to have.
- First commit to issue fork.
- ๐ซ๐ทFrance andypost
There's still little lag in current Firefox but is it really a blocker?
- ๐ท๐ธSerbia finnsky
little lag in current Firefox but is it really a blocker
I don't think so. Probably it may be fixed or even ignored.
- ๐ฎ๐ณIndia keshav patel
Keshav Patel โ made their first commit to this issueโs fork.
- Status changed to Needs review
10 months ago 12:31pm 10 March 2024 - Status changed to Needs work
10 months ago 5:49pm 10 March 2024 - ๐ท๐ธSerbia finnsky
- I adjusted the styles for Olivero and Claro.
- Added a label for accessibilityWhat's left to do:
- Correct styles for Umami (it is possible to remove them completely from Umami. Because they look strange even before the patch)
- Figure out what to do with stable9 styles
- Figure out what to do with the starter kit.Moving back to work
Would be cool if anyone could test it.
- ๐จ๐ฆCanada mgifford Ottawa, Ontario
Worth comparing with https://dequeuniversity.com/library/aria/progress-bar-bounded
Many uses of progress bars are essentially static, but Drupal we often use them as dynamic elements which should be updated with aria-live.
Deque uses:
<div id="progressbar-bounded" class="deque-progressbar deque-progressbar-bounded"> <progress role="progressbar" aria-valuemin="0" aria-valuemax="100" aria-label="A bounded progress bar from 0 to 100"> </progress> <p> <button class="deque-button" id="start-progressbar"> Start </button> </p> </div>
They leverage the ARIA progressbar role. I"m not certain that this is needed, but wanted to note it here.
MDN just states:
If the progressbar role is applied to an HTML
element, the accessible name can come from the associated . Otherwise use aria-labelledby if a visible label is present or aria-label if a visible label is not present.What is in the latest patch I think is:
<div id="${id}" class="progress" aria-live="polite"> <label> <div class="progress__label"> </div> <progress class="progress__element" value="0" max="100"></progress> </label> <div class="progress__percentage"></div> <div class="progress__description"> </div> </div>
I'm not sure how much the JavaScript would affect things here either. I haven't compared the two.